From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 10/10] net/virtio: improve batching in
 standard Rx path
Date: Tue, 19 Mar 2019 18:28:53 +0800
Message-ID: <20190319102852.GA8090@dpdk-tbie.sh.intel.com>
References: <20190319064312.13743-1-tiwei.bie@intel.com>
 <20190319064312.13743-11-tiwei.bie@intel.com>
 <20190319100424.oajlkmjiahdka373@jenstp.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
To: Jens Freimann <jfreimann@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D0F9311A4
 for <dev@dpdk.org>; Tue, 19 Mar 2019 11:29:09 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20190319100424.oajlkmjiahdka373@jenstp.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 19, 2019 at 11:04:24AM +0100, Jens Freimann wrote:
> On Tue, Mar 19, 2019 at 02:43:12PM +0800, Tiwei Bie wrote:
> > This patch improves descriptors refill by using the same
> > batching strategy as done in in-order and mergeable path.
> > 
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > drivers/net/virtio/virtio_rxtx.c | 60 ++++++++++++++++++--------------
> > 1 file changed, 34 insertions(+), 26 deletions(-)
> > 
> Looks good. How much do we gain by this?

The gain is very visible on my side. E.g. for packed ring,
the PPS changed from ~10786973 to ~11636990 in a macfwd test
between two testpmds.

Thanks,
Tiwei

> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
> 
>