From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v2 6/6] app/testpmd: add mempool flags
 parameter
Date: Wed, 20 Mar 2019 23:22:16 +0800
Message-ID: <20190320152216.GB49599@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190319071256.26302-1-xiaolong.ye@intel.com>
 <20190319071256.26302-7-xiaolong.ye@intel.com>
 <b9834d2e5e48a7bfbdedbcfc942b191bc0fc95f4.camel@marvell.com>
 <CAJFAV8wsbGfXz=3_QBtwYYfaep2oh6KQ3R3DeyYZo3wdWRbi2Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "magnus.karlsson@intel.com" <magnus.karlsson@intel.com>,
 "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
 "bjorn.topel@intel.com" <bjorn.topel@intel.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id C81B94F9A
 for <dev@dpdk.org>; Wed, 20 Mar 2019 16:26:17 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAJFAV8wsbGfXz=3_QBtwYYfaep2oh6KQ3R3DeyYZo3wdWRbi2Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/20, David Marchand wrote:
>On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran <
>jerinj@marvell.com> wrote:
>
>> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote:
>> > When create rte_mempool, flags can be parsed from command line.
>> > Now, it is possible for testpmd to create a af_xdp friendly
>> > mempool (which enable zero copy).
>> >
>> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> > ---
>> >  app/test-pmd/parameters.c             | 12 ++++++++++++
>> >  app/test-pmd/testpmd.c                | 17 ++++++++++-------
>> >  app/test-pmd/testpmd.h                |  1 +
>> >  doc/guides/testpmd_app_ug/run_app.rst |  4 ++++
>>
>> If I understand it correctly, The user needs to change all the
>> application in order to avail zero copy feature of XDP.
>>
>> If so,
>>
>> How about creating wrapper mempool driver for xdp at drivers/mempool/?
>> and mempool's best mempool feature to select the required mempool
>> driver for XDP at runtime without changing the apps.
>>
>> see rte_mbuf_best_mempool_ops()
>> see struct eth_dev_ops::pool_ops_supported
>>
>
>Glab to read this, I was under the same impression :-)

We plan to separate this in another patchset and may target for next release.

Thanks,
Xiaolong
>
>
>-- 
>David Marchand