From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver Date: Thu, 21 Mar 2019 08:27:05 -0700 Message-ID: <20190321082705.1ee71f1f@shemminger-XPS-13-9360> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn To: Xiaolong Ye Return-path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 2B90B1B501 for ; Thu, 21 Mar 2019 16:27:10 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id p6so4423445pgh.9 for ; Thu, 21 Mar 2019 08:27:10 -0700 (PDT) In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > static void kick_tx(struct pkt_tx_queue *txq) > +{ > + struct xsk_umem_info *umem = txq->pair->umem; > + > + while (send(xsk_socket__fd(txq->pair->xsk), NULL, > + 0, MSG_DONTWAIT) < 0) { > + /* some thing unexpected */ > + if (errno != EBUSY && errno != EAGAIN) > + break; > + > + /* pull from complete qeueu to leave more space */ > + if (errno == EAGAIN) > + pull_umem_cq(umem, ETH_AF_XDP_TX_BATCH_SIZE); > + } What about EINTR?? You should retry the send then.