From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD
 driver
Date: Thu, 21 Mar 2019 08:31:21 -0700
Message-ID: <20190321083121.15e6dfb1@shemminger-XPS-13-9360>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190321091845.78495-1-xiaolong.ye@intel.com>
 <20190321091845.78495-2-xiaolong.ye@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>, Karlsson Magnus
 <magnus.karlsson@intel.com>, Topel Bjorn <bjorn.topel@intel.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com
 [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id C4ED61B51D
 for <dev@dpdk.org>; Thu, 21 Mar 2019 16:31:25 +0100 (CET)
Received: by mail-pf1-f181.google.com with SMTP id 8so4533610pfr.4
 for <dev@dpdk.org>; Thu, 21 Mar 2019 08:31:25 -0700 (PDT)
In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 21 Mar 2019 17:18:41 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> +	if (strnlen(value, IFNAMSIZ) > IFNAMSIZ - 1) {
> +		RTE_LOG(ERR, AF_XDP, "Invalid name %s, should be less than "
> +			"%u bytes.\n", value, IFNAMSIZ)

Please don't break error message strings across multiple source lines.
It makes it harder to use tools like grep to find errors in source.