From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver Date: Thu, 21 Mar 2019 08:36:34 -0700 Message-ID: <20190321083634.70220adb@shemminger-XPS-13-9360> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn To: Xiaolong Ye Return-path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 111CD4CC7 for ; Thu, 21 Mar 2019 16:36:40 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id c207so4534214pfc.7 for ; Thu, 21 Mar 2019 08:36:39 -0700 (PDT) In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > + > +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); The convention in other network drivers is to use net_XXX in the vdev name. In AF_XDP that would be: RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); About naming, I would just drop AF_ from the name everywhere, the driver is about running over XDP, and the "AF_" is just a prefix for address family. Why not: net/xdp