From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver Date: Fri, 22 Mar 2019 08:37:46 -0700 Message-ID: <20190322083746.12467e17@shemminger-XPS-13-9360> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083000.5894dbf7@shemminger-XPS-13-9360> <20190322020157.GD84243@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn To: Ye Xiaolong Return-path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id C134D4C9F for ; Fri, 22 Mar 2019 16:37:50 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id 8so1791028pfr.4 for ; Fri, 22 Mar 2019 08:37:50 -0700 (PDT) In-Reply-To: <20190322020157.GD84243@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 22 Mar 2019 10:01:57 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> + if (ret < 0) > >> + return -EINVAL; > >> + > >> + return 0; > > > >You could propogate kernel errno into DPDK? > > return (ret < 0) ? -errno : 0; > > > > Sorry, could you share the advantage of doing this? > > Thanks, > Xiaolong Suppose kernel returned -ENOTSUPP or other error, it could go back to the caller rather than juse invalid.