From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD
	driver
Date: Fri, 22 Mar 2019 09:32:05 +0000
Message-ID: <20190322093204.GA119220@bricha3-MOBL.ger.corp.intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190321091845.78495-1-xiaolong.ye@intel.com>
 <20190321091845.78495-2-xiaolong.ye@intel.com>
 <20190321083634.70220adb@shemminger-XPS-13-9360>
 <20190322014903.GA84243@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
 Qi Zhang <qi.z.zhang@intel.com>,
 Karlsson Magnus <magnus.karlsson@intel.com>,
 Topel Bjorn <bjorn.topel@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 69E351B588
 for <dev@dpdk.org>; Fri, 22 Mar 2019 10:32:10 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20190322014903.GA84243@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 22, 2019 at 09:49:03AM +0800, Ye Xiaolong wrote:
> On 03/21, Stephen Hemminger wrote:
> >On Thu, 21 Mar 2019 17:18:41 +0800
> >Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> >
> >> +
> >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv);
> >
> >The convention in other network drivers is to use net_XXX in the vdev name.
> >In AF_XDP that would be:
> >
> >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv);
> 
> Got it.
> 
> >
> >About naming, I would just drop AF_ from the name everywhere, the driver
> >is about running over XDP, and the "AF_" is just a prefix for address family.
> >
> >Why not:
> >	net/xdp
> 
> Thanks for the advice, Actually this driver is more about AF_XDP rathan than
> XDP, the foundational objects it uses such as umem, umem fill ring, umem
> completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would
> rather keep the naming.
> 
+1 for the naming. AF_XDP is something different from XDP itself, though
the former does use the latter.

/Bruce