From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD
	driver
Date: Sat, 23 Mar 2019 07:20:10 +0800
Message-ID: <20190322232010.GC15995@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190321091845.78495-1-xiaolong.ye@intel.com>
 <20190321091845.78495-2-xiaolong.ye@intel.com>
 <20190321082822.2660e913@shemminger-XPS-13-9360>
 <20190322021523.GH84243@intel.com>
 <20190322083838.1da3e00e@shemminger-XPS-13-9360>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
 Karlsson Magnus <magnus.karlsson@intel.com>,
 Topel Bjorn <bjorn.topel@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 655971B765
 for <dev@dpdk.org>; Sat, 23 Mar 2019 00:24:20 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20190322083838.1da3e00e@shemminger-XPS-13-9360>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/22, Stephen Hemminger wrote:
>On Fri, 22 Mar 2019 10:15:23 +0800
>Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
>> On 03/21, Stephen Hemminger wrote:
>> >On Thu, 21 Mar 2019 17:18:41 +0800
>> >Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>> >  
>> >> +		if (ret != 0) {
>> >> +			RTE_LOG(ERR, AF_XDP, "getsockopt() failed for XDP_STATISTICS.\n");
>> >> +			return -1;  
>> >
>> >You need to use the new dynamic log types and not have a global logtype.  
>> 
>> You mean for all the logs in this driver, right? Is it due to the global logtype
>> will be deprecated?
>
>Global log types should not be used or added by any new code.

Got it.