From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver Date: Mon, 25 Mar 2019 08:58:14 -0700 Message-ID: <20190325085814.1cca7845@shemminger-XPS-13-9360> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190325060400.40291-1-xiaolong.ye@intel.com> <20190325060400.40291-2-xiaolong.ye@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, David Marchand , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Ferruh Yigit , Luca Boccassi , Bruce Richardson , Ananyev Konstantin To: Xiaolong Ye Return-path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 9DE972BD3 for ; Mon, 25 Mar 2019 16:58:19 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id k3so3096372pga.6 for ; Mon, 25 Mar 2019 08:58:19 -0700 (PDT) In-Reply-To: <20190325060400.40291-2-xiaolong.ye@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 25 Mar 2019 14:03:56 +0800 Xiaolong Ye wrote: > + > + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); > + if (unlikely(!ret)) { > + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); You defined AF_XDP_LOG to add a newline (similar to other drivers). But all the messages already have a newline. This will cause log to be double spaced.