From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD
	driver
Date: Tue, 26 Mar 2019 10:13:36 +0800
Message-ID: <20190326021336.GA48057@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190325060400.40291-1-xiaolong.ye@intel.com>
 <20190325060400.40291-2-xiaolong.ye@intel.com>
 <20190325085814.1cca7845@shemminger-XPS-13-9360>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
 Qi Zhang <qi.z.zhang@intel.com>,
 Karlsson Magnus <magnus.karlsson@intel.com>,
 Topel Bjorn <bjorn.topel@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ananyev Konstantin <konstantin.ananyev@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id D23461150
 for <dev@dpdk.org>; Tue, 26 Mar 2019 03:17:58 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20190325085814.1cca7845@shemminger-XPS-13-9360>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/25, Stephen Hemminger wrote:
>On Mon, 25 Mar 2019 14:03:56 +0800
>Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> +
>> +	ret = xsk_ring_prod__reserve(fq, reserve_size, &idx);
>> +	if (unlikely(!ret)) {
>> +		AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n");
>
>You defined AF_XDP_LOG to add a newline (similar to other drivers).
>But all the messages already have a newline.
>This will cause log to be double spaced.

Thanks for the catch, I'll remove the newline in the definition.