From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v5 3/8] kvargs: adding a module definition
	file
Date: Tue, 26 Mar 2019 10:58:31 +0000
Message-ID: <20190326105831.GA188340@bricha3-MOBL.ger.corp.intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190326060238.9884-1-anand.rawat@intel.com>
 <20190326060238.9884-4-anand.rawat@intel.com>
 <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "anand.rawat@intel.com" <anand.rawat@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "ranjit.menon@intel.com" <ranjit.menon@intel.com>,
 "jeffrey.b.shaw@intel.com" <jeffrey.b.shaw@intel.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 4C4AA2BFA
 for <dev@dpdk.org>; Tue, 26 Mar 2019 11:58:37 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <13f7c718448539712a6ba5024959b296143555e6.camel@marvell.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 26, 2019 at 10:32:34AM +0000, Jerin Jacob Kollanukkaran wrote:
> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote:
> > adding a DEF file for kvargs to specify the exports
> > for the creation of the shared library.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> > Reviewed-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > ---
> >  lib/librte_kvargs/rte_kvargs_exports.def | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >  create mode 100644 lib/librte_kvargs/rte_kvargs_exports.def
> > 
> > diff --git a/lib/librte_kvargs/rte_kvargs_exports.def
> > b/lib/librte_kvargs/rte_kvargs_exports.def
> > new file mode 100644
> > index 000000000..265d3cc9a
> > --- /dev/null
> > +++ b/lib/librte_kvargs/rte_kvargs_exports.def
> 
> Maintaining two separate files (.map and .def) for shared 
> library definition will be pain full.
>

Yes, though I'd question how much more painful it is than having to update
a separate map file anyway - just consider the number of patches that have
been submitted over the years which failed shared library build because map
file updates were forgotten.

However, my hope is that down the road we can have the def file generated
from the map file (or potentially vice versa). Perhaps the meson python
module could be used to allow us to script it a bit.

> # Is it possible to add neutral file format if windows is not happy
> with .map file?
> # I am not sure, How we can express "EXPERIMENTAL" tag with .def file.
> # It is good to check, How  OTHER cross platform libraries addressing
> this problem
> 
A wider question is whether it is possible at all to have ABI versions
associated with functions? I didn't find any mention of it in the
documentations, and if it's not possible, then the question of how to put
an experimental version is moot, I think.

/Bruce