From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darek Stojaczyk Subject: [PATCH] fbarray: fix attach deadlock Date: Fri, 29 Mar 2019 06:09:51 +0100 Message-ID: <20190329050951.153202-1-dariusz.stojaczyk@intel.com> Cc: james.r.harris@intel.com, changpeng.liu@intel.com, Darek Stojaczyk , anatoly.burakov@intel.com, thomas@monjalon.net To: dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D96291DB8 for ; Fri, 29 Mar 2019 06:10:17 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_fbarray_attach() currently locks its internal spinlock, but never releases it. Secondary processes won't even start if there is more than one fbarray to be attached to - the second rte_fbarray_attach() would be just stuck. Fix it by releasing the lock at the end of rte_fbarray_attach(). I believe this was the original intention. Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for mapped areas") Cc: anatoly.burakov@intel.com Cc: thomas@monjalon.net Signed-off-by: Darek Stojaczyk --- lib/librte_eal/common/eal_common_fbarray.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c index 0e7366e5e..5ca8d6f0e 100644 --- a/lib/librte_eal/common/eal_common_fbarray.c +++ b/lib/librte_eal/common/eal_common_fbarray.c @@ -906,6 +906,7 @@ rte_fbarray_attach(struct rte_fbarray *arr) /* we're done */ + rte_spinlock_unlock(&mem_area_lock); return 0; fail: if (data) @@ -913,6 +914,7 @@ rte_fbarray_attach(struct rte_fbarray *arr) if (fd >= 0) close(fd); free(ma); + rte_spinlock_unlock(&mem_area_lock); return -1; } -- 2.17.1