From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH v2] mbuf: move headers not fragmented check to checksum Date: Fri, 29 Mar 2019 15:18:52 +0100 Message-ID: <20190329141852.h2kr3axi4cqdix6n@platinum> References: <1548751746-16030-1-git-send-email-arybchenko@solarflare.com> <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tomasz Kulasek , dev@dpdk.org, Konstantin Ananyev To: Andrew Rybchenko Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id DCD323256 for ; Fri, 29 Mar 2019 15:18:57 +0100 (CET) Content-Disposition: inline In-Reply-To: <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote: > rte_validate_tx_offload() is used in Tx prepare callbacks > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > Requirement that packet headers should not be fragmented is not > documented and unclear where it comes from except > rte_net_intel_cksum_prepare() functions which relies on it. > > It could be NIC vendor specific driver or hardware limitation, but, > if so, it should be documented and checked in corresponding Tx > prepare callbacks. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz Thanks!