From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v7 1/8] eal: eal stub to add windows support
Date: Mon, 1 Apr 2019 17:17:25 +0100
Message-ID: <20190401161725.GA1457@bricha3-MOBL.ger.corp.intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328232451.16988-1-anand.rawat@intel.com>
 <20190328232451.16988-2-anand.rawat@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, thomas@monjalon.net
To: Anand Rawat <anand.rawat@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 75FF74CC5
 for <dev@dpdk.org>; Mon,  1 Apr 2019 18:17:30 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote:
> Added initial stub source files for windows support
> and only the required meson changes for windows.
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  config/meson.build                      | 23 ++++++++++++------
>  config/x86/meson.build                  | 14 ++++++-----
>  lib/librte_eal/meson.build              |  6 ++++-
>  lib/librte_eal/windows/eal/eal.c        | 14 +++++++++++
>  lib/librte_eal/windows/eal/eal_debug.c  | 15 ++++++++++++
>  lib/librte_eal/windows/eal/eal_lcore.c  | 32 +++++++++++++++++++++++++
>  lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++
>  lib/librte_eal/windows/eal/meson.build  | 10 ++++++++
>  8 files changed, 118 insertions(+), 14 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal/eal.c
>  create mode 100644 lib/librte_eal/windows/eal/eal_debug.c
>  create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c
>  create mode 100644 lib/librte_eal/windows/eal/eal_thread.c
>  create mode 100644 lib/librte_eal/windows/eal/meson.build
> 
> diff --git a/config/meson.build b/config/meson.build
> index 30a7261a5..4bd73b1e9 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: BSD-3-Clause
> -# Copyright(c) 2017 Intel Corporation
> +# Copyright(c) 2017-2019 Intel Corporation
>  
>  # set the major version, which might be used by drivers and libraries
>  # depending on the configuration options
> @@ -80,18 +80,27 @@ dpdk_extra_ldflags += '-Wl,--no-as-needed'
>  add_project_link_arguments('-pthread', language: 'c')
>  dpdk_extra_ldflags += '-pthread'
>  
> -# some libs depend on maths lib
> -add_project_link_arguments('-lm', language: 'c')
> -dpdk_extra_ldflags += '-lm'
> +# on some OS, maths functions are in a separate library
> +if cc.find_library('lm', required : false).found()

The library is "libm", not "liblm" so this breaks the linux builds as there
is not found an "lm" library. Instead use "cc.find_library('m',..."

/Bruce