From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v7 1/8] eal: eal stub to add windows support Date: Mon, 1 Apr 2019 17:34:25 +0100 Message-ID: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net To: Anand Rawat Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E32EA5681 for ; Mon, 1 Apr 2019 18:34:30 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > Added initial stub source files for windows support > and only the required meson changes for windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Menon > --- > config/meson.build | 23 ++++++++++++------ > config/x86/meson.build | 14 ++++++----- > lib/librte_eal/meson.build | 6 ++++- > lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ > lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ > lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ > lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ > lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > 8 files changed, 118 insertions(+), 14 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/eal.c > create mode 100644 lib/librte_eal/windows/eal/eal_debug.c > create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c > create mode 100644 lib/librte_eal/windows/eal/eal_thread.c > create mode 100644 lib/librte_eal/windows/eal/meson.build > I'm a little uncertain behind putting the stub files and the meson.build changes in the one patch, since the result doesn't build anyway. However, you can get meson to successfully configure the project on windows by adding in an empty file called meson.build to the kernel/windows directory. /Bruce