From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v8 1/1] net/af_xdp: introduce AF XDP PMD
	driver
Date: Tue, 2 Apr 2019 07:58:06 -0700
Message-ID: <20190402075806.7523ad34@shemminger-XPS-13-9360>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190402104554.110516-1-xiaolong.ye@intel.com>
 <20190402104554.110516-2-xiaolong.ye@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>, Andrew
 Rybchenko <arybchenko@solarflare.com>, Olivier Matz
 <olivier.matz@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>, Karlsson Magnus
 <magnus.karlsson@intel.com>, Topel Bjorn <bjorn.topel@intel.com>, Maxime
 Coquelin <maxime.coquelin@redhat.com>, Ferruh Yigit
 <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>, Bruce
 Richardson <bruce.richardson@intel.com>, Ananyev Konstantin
 <konstantin.ananyev@intel.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
 [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id E43863798
 for <dev@dpdk.org>; Tue,  2 Apr 2019 16:58:12 +0200 (CEST)
Received: by mail-pg1-f193.google.com with SMTP id f6so6696892pgs.8
 for <dev@dpdk.org>; Tue, 02 Apr 2019 07:58:12 -0700 (PDT)
In-Reply-To: <20190402104554.110516-2-xiaolong.ye@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  2 Apr 2019 18:45:54 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> +
> +#include <rte_mbuf.h>
> +#include <rte_ethdev_driver.h>
> +#include <rte_ethdev_vdev.h>
> +#include <rte_malloc.h>
> +#include <rte_kvargs.h>
> +#include <rte_bus_vdev.h>
> +#include <rte_string_fns.h>
> +
> +#include <linux/if_ether.h>
> +#include <linux/if_xdp.h>
> +#include <linux/if_link.h>
> +#include <asm/barrier.h>
> +#include <arpa/inet.h>
> +#include <net/if.h>
> +#include <sys/types.h>
> +#include <sys/socket.h>
> +#include <sys/ioctl.h>
> +#include <sys/mman.h>
> +#include <unistd.h>
> +#include <poll.h>
> +#include <bpf/bpf.h>
> +#include <xsk.h>

The ordering here seems surprising. The usual ordering is:

Libc includes:
#include <stdio.h>
...
Sys includes:
#include <sys/types.h>

Linux includes:
#include <linux/if_xdp.h>

DPDK includes:
#include <rte_mbuf.h>


If I run "Include what you use" it has different suggestions.
Some of which you should ignore but overall there are
several good ones.

rte_eth_af_xdp.c should add these lines:
#include <asm/int-ll64.h>           // for __u64
#include <bits/stdint-uintn.h>      // for uint16_t, uint64_t, uint32_t
#include <errno.h>                  // for EINVAL, errno, EAGAIN, ENOMEM, EBUSY
#include <netinet/in.h>             // for IPPROTO_IP
#include <rte_ethdev.h>             // for rte_eth_dev, rte_eth_dev_data
#include <stdlib.h>                 // for strtol
#include <string.h>                 // for NULL, memset, strlen
#include "rte_branch_prediction.h"  // for unlikely
#include "rte_common.h"             // for __rte_unused, RTE_MIN, RTE_PRIORI...
#include "rte_config.h"             // for RTE_PKTMBUF_HEADROOM
#include "rte_dev.h"                // for rte_device, RTE_PMD_REGISTER_PARA...
#include "rte_eal.h"                // for rte_eal_process_type, rte_proc_ty...
#include "rte_ethdev.h"             // for rte_eth_stats, rte_eth_dev_info
#include "rte_ether.h"              // for ETHER_ADDR_LEN, ether_addr
#include "rte_lcore.h"              // for rte_socket_id
#include "rte_log.h"                // for rte_log, RTE_LOG_ERR, RTE_LOG_INFO
#include "rte_memory.h"             // for SOCKET_ID_ANY
#include "rte_memzone.h"            // for rte_memzone_free, RTE_MEMZONE_IOV...
#include "rte_ring.h"               // for rte_ring_free, rte_ring_create
struct rte_mempool;

rte_eth_af_xdp.c should remove these lines:
- #include <arpa/inet.h>  // lines 17-17
- #include <poll.h>  // lines 24-24
- #include <rte_ethdev_vdev.h>  // lines 7-7
- #include <sys/mman.h>  // lines 22-22
- #include <sys/types.h>  // lines 19-19