From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD
	driver
Date: Thu, 4 Apr 2019 13:29:33 +0800
Message-ID: <20190404052933.GA45121@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190403165949.44857-1-xiaolong.ye@intel.com>
 <20190403165949.44857-2-xiaolong.ye@intel.com>
 <25be95ff-132c-9e3e-fe3d-b5aac3dfb388@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
 Luca Boccassi <bluca@debian.org>, Qi Zhang <qi.z.zhang@intel.com>,
 Karlsson Magnus <magnus.karlsson@intel.com>,
 Topel Bjorn <bjorn.topel@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ananyev Konstantin <konstantin.ananyev@intel.com>,
 David Marchand <david.marchand@redhat.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id B81B6293B
 for <dev@dpdk.org>; Thu,  4 Apr 2019 07:34:30 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <25be95ff-132c-9e3e-fe3d-b5aac3dfb388@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh

On 04/03, Ferruh Yigit wrote:
>On 4/3/2019 5:59 PM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>> 
>> This is the vanilla version PMD which just uses a raw buffer registered as
>> the umem.
>> 
>> [1] https://fosdem.org/2018/schedule/event/af_xdp/
>> [2] https://lwn.net/Articles/745934/
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>I am not able to test functionality but code looks good to me, I can compile via
>Makefile (with suggested steps in doc) but not able to build with meson, can you
>please check below comments?
>

My bad, sorry for not testing out meson build.

><...>
>
>> @@ -0,0 +1,21 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2019 Intel Corporation
>> +
>> +if host_machine.system() != 'linux'
>> +	build = false
>> +endif
>
>After this point, if build is false it shouldn't continue to below checks I think.

Make sense, will do.

>
>> +
>> +bpf_dep = dependency('libbpf', required: false)
>
>My library is in '/usr/local/lib64/libbpf.so' but this line can't find it. Where
>does 'dependency()' checks for libraries?
>
>> +if bpf_dep.found()
>> +	build = true
>> +else
>> +	bpf_dep = cc.find_library('libbpf', required: false)
>
>Also this line can't find it, in log it says "(tried pkgconfig and cmake)" and
>yes there is no pkgconfig for it, any idea how 'cmake' used?

As Luca said, it should be cc.find_library('bpf', required: false), will correct
it in next version.

>
>> +	if bpf_dep.found() and cc.has_header('xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
>
>Should this be 'lib/xsk.h' now?

Will change to bpf/xsk.h in next version.

Thanks,
Xiaolong
>
>> +		build = true
>> +		pkgconfig_extra_libs += '-lbpf'
>> +	else
>> +		build = false
>> +	endif
>> +endif
>> +sources = files('rte_eth_af_xdp.c')
>> +ext_deps += bpf_dep
>