From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B87C0651F for ; Thu, 4 Jul 2019 16:27:09 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 08A73218A0 for ; Thu, 4 Jul 2019 16:27:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A73218A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A65531FC; Thu, 4 Jul 2019 18:27:08 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A2D8F2C2B; Thu, 4 Jul 2019 18:27:06 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 09:27:05 -0700 X-IronPort-AV: E=Sophos;i="5.63,451,1557212400"; d="scan'208";a="175287530" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 09:27:03 -0700 Date: Thu, 4 Jul 2019 17:27:00 +0100 From: Bruce Richardson To: Timothy Redaelli Cc: Thomas Monjalon , dev@dpdk.org, erik.g.carrillo@intel.com, stable@dpdk.org Message-ID: <20190704162700.GE439@bricha3-MOBL.ger.corp.intel.com> References: <59d6b403fd875f8dac9b4f3d85725b95cb462b17.1562254062.git.tredaelli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59d6b403fd875f8dac9b4f3d85725b95cb462b17.1562254062.git.tredaelli@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] test: fix build without timer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote: > The action for timer_secondary_spawn_wait should be enabled only when > CONFIG_RTE_LIBRTE_TIMER is enabled. > > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") > Cc: erik.g.carrillo@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Timothy Redaelli > --- Is there a reason why DPDK can't always be built with the timer library? It doesn't have any external dependencies, and having the ability to turn on and off various libraries individually in the build makes validating the combinations problematic. /Bruce