From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D02C4649B for ; Fri, 5 Jul 2019 13:48:15 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4CCFB20856 for ; Fri, 5 Jul 2019 13:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CCFB20856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=6wind.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 396641BEDE; Fri, 5 Jul 2019 15:48:14 +0200 (CEST) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 84A8A1BED3 for ; Fri, 5 Jul 2019 15:48:12 +0200 (CEST) Received: from lfbn-lil-1-176-160.w90-45.abo.wanadoo.fr ([90.45.26.160] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hjOcH-0004tL-9Q; Fri, 05 Jul 2019 15:51:10 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 05 Jul 2019 15:48:01 +0200 Date: Fri, 5 Jul 2019 15:48:01 +0200 From: Olivier Matz To: Thomas Monjalon Cc: "reshma.pattan@intel.com" , arybchenko@solarflare.com, dev@dpdk.org, Harman Kalra , Jerin Jacob Kollanukkaran Message-ID: <20190705134801.qirbqvafroci3oxv@platinum> References: <1552663632-18742-1-git-send-email-hkalra@marvell.com> <1649425.EjAGamAeX1@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649425.EjAGamAeX1@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] app/pdump: enforcing pdump to use sw mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Thu, Jul 04, 2019 at 06:29:25PM +0200, Thomas Monjalon wrote: > 15/03/2019 16:27, Harman Kalra: > > Since pdump uses SW rings to manage packets hence > > pdump should use SW ring mempool for managing its > > own copy of packets. > > I'm not sure to understand the reasoning. > Reshma, Olivier, Andrew, any opinion? > > Let's take a decision for this very old patch. >From what I understand, many mempools of packets are created, to store the copy of dumped packets. I suppose that it may not be possible to create as many mempools by using the "best" mbuf pool (from rte_mbuf_best_mempool_ops()). Using a "ring_mp_mc" as mempool ops should always be possible. I think it would be safer to use "ring_mp_mc" instead of CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS, because the latter could be overriden on a specific platform. Olivier