From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832FBC433FF for ; Wed, 31 Jul 2019 15:38:49 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 42D14206B8 for ; Wed, 31 Jul 2019 15:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42D14206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CEB21BFC1; Wed, 31 Jul 2019 17:38:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2F1F61BF1A for ; Wed, 31 Jul 2019 17:38:46 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 08:38:44 -0700 X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="371562049" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.61]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 08:38:43 -0700 Date: Wed, 31 Jul 2019 16:38:41 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190731153841.GH1705@bricha3-MOBL.ger.corp.intel.com> References: <20190731145742.10776-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731145742.10776-1-stephen@networkplumber.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote: > Using a simple shell script which cleans up trailing whitespace > found several places with extra lines at end of file. > > More in base drivers but they are known to be problematic. > > Stephen Hemminger (5): > examples: remove extra blank lines at eof > test: remove blank lines at eof > pmdinfogen: remove blank line at eof > net/ipn3ke: cleanup blank line at eof > net/mlx5: remove blank lines at eof > > app/test/test_cryptodev_asym_util.h | 4 ---- > app/test/test_table_combined.c | 1 - > app/test/test_table_tables.c | 3 +-- > buildtools/pmdinfogen/pmdinfogen.h | 1 - > drivers/net/ipn3ke/ipn3ke_flow.c | 1 - > drivers/net/ipn3ke/ipn3ke_tm.c | 1 - > drivers/net/mlx5/mlx5_rxtx.c | 2 -- > examples/flow_filtering/flow_blocks.c | 1 - > examples/l3fwd-power/perf_core.c | 1 - > examples/vhost_scsi/vhost_scsi.c | 1 - > 10 files changed, 1 insertion(+), 15 deletions(-) > Series-acked-by: Bruce Richardson I really wonder if removing blank lines at EOF would really be a problem for base drivers? Seems like it should not be a major issue, but perhaps maintainers best comment first.