From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F4EC3A5A2 for ; Fri, 23 Aug 2019 15:30:18 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 964E22133F for ; Fri, 23 Aug 2019 15:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964E22133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tuxdriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D2B91C066; Fri, 23 Aug 2019 17:30:12 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A3C131C043; Fri, 23 Aug 2019 17:30:10 +0200 (CEST) Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1i1BVx-0007We-2R; Fri, 23 Aug 2019 11:30:09 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x7NFSkqt006246; Fri, 23 Aug 2019 11:28:46 -0400 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x7NFSk6e006245; Fri, 23 Aug 2019 11:28:46 -0400 Date: Fri, 23 Aug 2019 11:28:46 -0400 From: "John W. Linville" To: Abhishek Sachan Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190823152846.GA6221@tuxdriver.com> References: <1566455136-8496-1-git-send-email-abhishek.sachan@altran.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566455136-8496-1-git-send-email-abhishek.sachan@altran.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix for stale sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 22, 2019 at 11:55:36AM +0530, Abhishek Sachan wrote: > af_packet driver is leaving stale socket after device is removed. > Ring buffers are memory mapped when device is added using rte_dev_probe. > There is no corresponding munmap call when device is removed/closed. > This commit fixes the issue by calling munmap > from rte_pmd_af_packet_remove(). > > Bugzilla ID: 339 > Cc: stable@dpdk.org > > Signed-off-by: Abhishek Sachan > Reviewed-by: John W. Linville Confirmed... Reviewed-by: John W. Linville John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.