From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB760C4360C for ; Fri, 27 Sep 2019 20:48:28 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9D0B6207E0 for ; Fri, 27 Sep 2019 20:48:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D0B6207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19CCB1BEF2; Fri, 27 Sep 2019 22:48:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1B1B81BEF0 for ; Fri, 27 Sep 2019 22:48:24 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 13:48:23 -0700 X-IronPort-AV: E=Sophos;i="5.64,556,1559545200"; d="scan'208";a="193368464" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.31.249]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 13:48:21 -0700 Date: Fri, 27 Sep 2019 21:48:16 +0100 From: Bruce Richardson To: dev@dpdk.org Cc: Andrzej Ostruszka , Thomas Monjalon , Ray Kinsella , Neil Horman Message-ID: <20190927204816.GA1875@bricha3-MOBL.ger.corp.intel.com> References: <20190927194932.22197-1-bruce.richardson@intel.com> <20190927194932.22197-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190927194932.22197-2-bruce.richardson@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 1/2] eal: split compat header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 27, 2019 at 08:49:31PM +0100, Bruce Richardson wrote: > The compat.h header file provided macros for two purposes: > 1. it provided the macros for marking functions as rte_experimental > 2. it provided the macros for doing function versioning > > Although these were in the same file, #1 is something that is for use by > public header files, which #2 is for internal use only. Therefore, we can > split these into two headers, keeping #1 in rte_compat.h and #2 in a new > file rte_function_versioning.h. For "make" builds, since internal objects > pick up the headers from the "include/" folder, we need to add the new > header to the installation list, but for "meson" builds it does not need to > be installed as it's not for public use. > > The rework also serves to allow the use of the function versioning macros > to files that actually need them, so the use of experimental functions does > not need including of the versioning code. > > Signed-off-by: Bruce Richardson > --- > doc/api/doxy-api-index.md | 3 ++- > doc/guides/contributing/versioning.rst | 4 ++-- > lib/librte_distributor/rte_distributor.c | 2 +- > lib/librte_distributor/rte_distributor_v20.c | 2 +- > lib/librte_eal/common/Makefile | 1 + > ...rte_compat.h => rte_function_versioning.h} | 19 +++---------------- > lib/librte_lpm/rte_lpm.c | 1 + > lib/librte_lpm/rte_lpm.h | 1 - > lib/librte_lpm/rte_lpm6.c | 1 + > lib/librte_timer/rte_timer.c | 2 +- > 10 files changed, 13 insertions(+), 23 deletions(-) > rename lib/librte_eal/common/include/{rte_compat.h => rte_function_versioning.h} (89%) > Apologies, but one of the parts of the split file somehow missed making the patch. I'll do a v2 soon.