From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2667C10F14 for ; Thu, 3 Oct 2019 09:21:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 84B882133F for ; Thu, 3 Oct 2019 09:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84B882133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 822401C025; Thu, 3 Oct 2019 11:21:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8C6B01BFDC for ; Thu, 3 Oct 2019 11:21:22 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 02:21:21 -0700 X-IronPort-AV: E=Sophos;i="5.67,251,1566889200"; d="scan'208";a="275658387" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 02:21:20 -0700 Date: Thu, 3 Oct 2019 10:21:17 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20191003092117.GA1803@bricha3-MOBL.ger.corp.intel.com> References: <1570035347-18360-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570035347-18360-1-git-send-email-david.marchand@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 02, 2019 at 06:55:47PM +0200, David Marchand wrote: > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS > for cross compilation or libraries that won't provide a pkg-config file. > > Fixes: 272236741258 ("devtools: load target-specific compilation environment") > > Signed-off-by: David Marchand > --- No strong objection to this change, but for meson the better way to handle this may be to put these flags into the cross-file used for the build. By explicitly passing CFLAGS etc. to the build, I'm not sure what the behaviour is with regards to passing those flags to cross-built vs native-built components. For a cross-compile, not all CFLAGS should be passed to the build of pmdinfogen, for instance. /Bruce