From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56B3CA9EC5 for ; Wed, 30 Oct 2019 14:04:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8D54D20874 for ; Wed, 30 Oct 2019 14:04:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D54D20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40EFB1BFC0; Wed, 30 Oct 2019 15:04:55 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 938E11BFA9; Wed, 30 Oct 2019 15:04:53 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 07:04:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="230455333" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2019 07:04:50 -0700 Date: Wed, 30 Oct 2019 22:01:16 +0800 From: Ye Xiaolong To: Mesut Ali Ergin Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191030140115.GH11315@intel.com> References: <1559583889-277418-1-git-send-email-mesut.a.ergin@intel.com> <20191028074109.GG33024@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028074109.GG33024@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Latest update, since i40e now has added FDIR ID to vector rx after patchset https://patches.dpdk.org/cover/60820/ being merged, this patch is no longer needed, so just drop it from next-net-intel. Thanks, Xiaolong On 10/28, Ye Xiaolong wrote: >Sorry for missing this patch for a long time. > >On 06/03, Mesut Ali Ergin wrote: >>Runtime requests to install an rte_flow with MARK action should fail >>if the device was started and a vector RX function was already chosen >>for during configuration time. >> >>Currently, i40e rte_flow driver would successfully install the flow >>with MARK action, even when vector RX functions are in use. However, >>those vector RX functions will fail to retrieve the MARK data from the >>device descriptor into the mbuf. The original app installing the flow >>would never know what went wrong. The function introduced in this patch >>must be adjusted if/when certain vector RX functions start supporting >>correct FDIR processing for MARK actions. >> >>Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") >>Cc: stable@dpdk.org >> >>Signed-off-by: Mesut Ali Ergin >> >>v3: >> - Check for support made in an function for future extensibility >> - Fixes code style warnings >> - CC stable w/ fix reference >>v2: >> - Check added to fail MARK request only if the device was started >>--- > >Minor nit, you should put the change logs after above '---' line, then they can be >ignored when git-am, fix it while merging. > >> drivers/net/i40e/i40e_flow.c | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) > >Reviewed-by: Xiaolong Ye > >Applied to dpdk-next-net-intel. Thanks.