From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EAD8C43215 for ; Fri, 15 Nov 2019 10:41:52 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 294192073B for ; Fri, 15 Nov 2019 10:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 294192073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 627062B87; Fri, 15 Nov 2019 11:41:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C01572B86; Fri, 15 Nov 2019 11:41:49 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 02:41:40 -0800 X-IronPort-AV: E=Sophos;i="5.68,308,1569308400"; d="scan'208";a="199162723" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Nov 2019 02:41:38 -0800 Date: Fri, 15 Nov 2019 10:41:35 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org Message-ID: <20191115104135.GA1517@bricha3-MOBL.ger.corp.intel.com> References: <20191115103525.94786-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115103525.94786-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] devtools: fix example build with old pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 15, 2019 at 10:35:25AM +0000, Ferruh Yigit wrote: > The old version of the pkg-config [1] doesn't support '-define-prefix' > and '--path' arguments which is causing failure building the > examples [2]. > Yes for the define-prefix option, no for the path one. The define-prefix argument is indeed necessary to have a properly working pkg-config to get cflags/ldflags in this case, so we need to skip the tests without it. However, the path parameter is only used to properly track the dependencies of the build to enable rebuilding if the pkg-config file itself changes. Therefore, having no output from pkg-config --path won't cause the build to fail, so it's more an optional flag. /Bruce