From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20713C432C0 for ; Mon, 25 Nov 2019 08:10:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AFF74207FD for ; Mon, 25 Nov 2019 08:10:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RtQiNQQr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFF74207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF1865596; Mon, 25 Nov 2019 09:10:28 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3212A4CA6 for ; Mon, 25 Nov 2019 09:10:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574669426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGb43gjI1KKafb6uamCXYxzmgnNvFWSZzrGQuK7WvuI=; b=RtQiNQQrsV1y2auomVXJsMeF9kiQZBibd+8KezyQtQsR97F3F/uMIqZEignwuZIOfyhyRY uywQzigpjXcnCVmsg0KymlWv/TV8OIrUgV9brdeHe5bQFLsq40Gxq6zWvhkrGFgZEVYHH3 GzPb2d6ymix1igY1lXTTkygHM8hWPqo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-ueMNFm-RMlyyG3MHyUQ89A-1; Mon, 25 Nov 2019 03:10:23 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CDFD1005509; Mon, 25 Nov 2019 08:10:21 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-70.brq.redhat.com [10.40.204.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 127FC60F8A; Mon, 25 Nov 2019 08:10:18 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, arybchenko@solarflare.com, stable@dpdk.org, Neil Horman Date: Mon, 25 Nov 2019 09:10:07 +0100 Message-Id: <20191125081007.12396-2-david.marchand@redhat.com> In-Reply-To: <20191125081007.12396-1-david.marchand@redhat.com> References: <20191125081007.12396-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: ueMNFm-RMlyyG3MHyUQ89A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH 2/2] buildtools: fix build with coverage enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A compiler can reuse a variable name and prefix it when instrumenting with coverage. Example: $ make defconfig T=3Dx86_64-native-linux-gcc O=3Dmaster $ make EXTRA_CFLAGS=3D'--coverage' O=3Dmaster [...] CC rte_flow.o rte_flow_dynf_metadata_offs is not flagged as experimental but is listed in version map Please add __rte_experimental to the definition of rte_flow_dynf_metadata_offs $ objdump -t master/build/lib/librte_ethdev/rte_flow.o |grep _offs$ 0000000000000000 l F .text.startup=09000000000000000a _GLOBAL__sub_I_65535_0_rte_flow_dynf_metadata_offs 0000000000000620 g O .data=090000000000000004 rte_flow_dynf_metadata_offs Protect against this by adding a space character in the pattern. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API expo= rts") Cc: stable@dpdk.org Reported-by: Andrew Rybchenko Signed-off-by: David Marchand --- buildtools/check-experimental-syms.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-exper= imental-syms.sh index abebb89f12..f3603e5bac 100755 --- a/buildtools/check-experimental-syms.sh +++ b/buildtools/check-experimental-syms.sh @@ -25,8 +25,8 @@ objdump -t $OBJFILE >$DUMPFILE ret=3D0 for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3` do -=09if grep -q "\.text.*$SYM$" $DUMPFILE && -=09=09! grep -q "\.text\.experimental.*$SYM$" $DUMPFILE +=09if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE && +=09=09! grep -q "\.text\.experimental.*[[:space:]]$SYM$" $DUMPFILE =09then =09=09cat >&2 <<- END_OF_MESSAGE =09=09$SYM is not flagged as experimental --=20 2.23.0