From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] crypto/scheduler: fix include of local headers Date: Tue, 28 Mar 2017 05:04:01 -0700 (PDT) Message-ID: <2019151.ZOXWie8io1@xps13> References: <20170328105816.22502-1-bruce.richardson@intel.com> <20170328110448.GA22460@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, roy.fan.zhang@intel.com, stable@dpdk.org To: Bruce Richardson Return-path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id D6CCBD1E8 for ; Tue, 28 Mar 2017 14:04:02 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id z15so36548101lfd.1 for ; Tue, 28 Mar 2017 05:04:02 -0700 (PDT) In-Reply-To: <20170328110448.GA22460@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-28 12:04, Bruce Richardson: > On Tue, Mar 28, 2017 at 11:58:16AM +0100, Bruce Richardson wrote: > > When a C file for a library/driver is including the public header files for > > that library, those need to be included as local includes using quotes > > rather than angle-brackets. Without doing so, parallel builds can fail, as > > the compiler will only look for those headers in the global include folder > > rather than locally, and the build system does not enforce that the headers > > for a lib are installed before the rest of the lib is compiled. > > > > Fixes: 097ab0bac017 ("crypto/scheduler: add API") > > Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") > > Fixes: 31439ee72b2c ("crypto/scheduler: add API implementations") > > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson > > --- > > drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 2 +- > > drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 2 +- > > drivers/crypto/scheduler/scheduler_pmd.c | 2 +- > > drivers/crypto/scheduler/scheduler_pmd_private.h | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > Two follow-up points: > > * Even though this is a crypto patch, I think it should go in main tree > as builds are broken right now if you turn on the PMD and use a large > -j setting. (i.e. it's broken for me!! :-) ) Applied, thanks for catching > * Is there a reason why this PMD is disabled by default? It doesn't > appear to have any external dependencies and if we turn it on by > default we should be able to catch issues like this a lot quicker. I forgot to check this PMD. I was not compiling it either. I agree it should be enabled by default, or at least enabled in test-build.sh.