From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] kni: unregister an unregisterd net_device
	could cause a kernel crash
Date: Fri, 09 Sep 2016 14:40:27 +0200
Message-ID: <2019611.627KgLZ47A@xps13>
References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com>
 <20160908094442.4dfa5b01@xeon-e3>
 <05b14d74-b168-69b2-b107-124ee951dc27@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 zhouyangchao <zhouyates@gmail.com>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 9A8196CD1
 for <dev@dpdk.org>; Fri,  9 Sep 2016 14:40:29 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id 1so30637212wmz.1
 for <dev@dpdk.org>; Fri, 09 Sep 2016 05:40:29 -0700 (PDT)
In-Reply-To: <05b14d74-b168-69b2-b107-124ee951dc27@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-08 18:15, Ferruh Yigit:
> On 9/8/2016 5:44 PM, Stephen Hemminger wrote:
> 
> ...
> 
> > But then again the whole KNI driver fails completely when
> > running kernel style check.
> > 
> 
> Yes, it generates lots of warnings.
> I can fix them (excluding ethtool/*), that wouldn't take much time but
> how syntax only patches welcomed? Another concern is it trashes git blame.

You ask a question and give the answer ;)
I think it depends just on the balance of the pros/cons - to be evaluated.