From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995C2C33CB1 for ; Tue, 14 Jan 2020 09:10:10 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4421B2075B for ; Tue, 14 Jan 2020 09:10:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4421B2075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chelsio.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D37F1C25A; Tue, 14 Jan 2020 10:10:09 +0100 (CET) Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id 8A7031C23F for ; Tue, 14 Jan 2020 10:10:08 +0100 (CET) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 00E9A3I1029732; Tue, 14 Jan 2020 01:10:04 -0800 Date: Tue, 14 Jan 2020 14:30:40 +0530 From: Rahul Lakkireddy To: Chas Williams <3chas3@gmail.com> Cc: "dev@dpdk.org" , nirranjan@chelsio.com Message-ID: <20200114090039.GA1508@chelsio.com> References: <7ba60c65-9448-7885-9932-7258202cef93@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ba60c65-9448-7885-9932-7258202cef93@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] net/cxgbe: DEV_TX_OFFLOAD_MULTI_SEGS support? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday, January 01/13/20, 2020 at 15:50:21 -0500, Chas Williams wrote: > > It looks like the cxgbe driver doesn't set the DEV_TX_OFFLOAD_MULTI_SEGS > offload capability. However, it looks like sge.c does have support for > sending mbuf chains, e.g. write_sgl(). Is this just an oversight or is > there something fundamentally broken here? Hi Chas, Thanks for reporting this. CXGBE does support transmitting mbufs with multiple segments. However, the corresponding DEV_TX_OFFLOAD_MULTI_SEGS capability seems to have been missed in the list of supported Tx offload features. Will send a patch to fix this. Thanks, Rahul