From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DAA9C43331 for ; Fri, 3 Apr 2020 09:36:11 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 024F020737 for ; Fri, 3 Apr 2020 09:36:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 024F020737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D634B1C128; Fri, 3 Apr 2020 11:36:09 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2F8C41C0D2 for ; Fri, 3 Apr 2020 11:36:06 +0200 (CEST) IronPort-SDR: EsHxYhVEzN2Q9ULTMJHdhTVHrNYrZEQheJq2Z5lsQiuGnpy6l6qWOMRyz3sug4SjxcpzhclysI 70cj0R/A0YWw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 02:36:04 -0700 IronPort-SDR: oeYM0VB+9Obgfs3ycm74yxofVxyTRP1xR37RI7z1+tXwdWBPBgLMOsraGLAdiul8RpLO8jUcXR fvxLZLO3rpfg== X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="423469762" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.36.192]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Apr 2020 02:36:02 -0700 Date: Fri, 3 Apr 2020 10:35:58 +0100 From: Bruce Richardson To: David Marchand Cc: Pavan Nikhilesh Bhagavatula , Jerin Jacob , Thomas Monjalon , Ferruh Yigit , dev , Neil Horman Message-ID: <20200403093558.GA547@bricha3-MOBL.ger.corp.intel.com> References: <20200402183253.866-1-jerinjacobk@gmail.com> <20200403091034.GA543@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 03, 2020 at 11:14:03AM +0200, David Marchand wrote: > On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson > wrote: > > > diff --git a/drivers/meson.build b/drivers/meson.build > > > index 987e616ae7..4d8f842ab8 100644 > > > --- a/drivers/meson.build > > > +++ b/drivers/meson.build > > > @@ -20,7 +20,7 @@ dpdk_driver_classes = ['common', > > > disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'), > > > ).stdout().split() > > > > > > -default_cflags = machine_args > > > +default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] > > > if cc.has_argument('-Wno-format-truncation') > > > default_cflags += '-Wno-format-truncation' > > > endif > > > > I see nothing wrong with that. > > > > Out of interest, is there a reason we don't just set it at the top level as > > a project c_arg, e.g. after setting "-include rte_config.h" in > > config/meson.build? > > As long as it is not inherited by examples and external apps, I am > fine with any simple solution :-). > It will be inherited by everything inside the current build, but building any examples separately or any external apps separately won't be affected. /Bruce