From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F783C2BA19 for ; Mon, 13 Apr 2020 15:23:12 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C0D8E2072C for ; Mon, 13 Apr 2020 15:23:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="fJl3fHHv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0D8E2072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 304771BF9E; Mon, 13 Apr 2020 17:23:11 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 085861BF67 for ; Mon, 13 Apr 2020 17:23:09 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id cl8so2761869pjb.3 for ; Mon, 13 Apr 2020 08:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Le/7zdHVCOzeBmqCe8n6AFtgKj3zkSauBjbRiX3YOG0=; b=fJl3fHHvCikDoOZ0PHwCy+xxX7osaDT2vvbh5x417iNXtiCQBoGY+UvspoaDadnbBJ r5Osmq0W6NRlJ3EKOvc60rqEsQsApAZ+zIsS6DXNk3xYLWhBep399FFXYfUW+Sckv6ZY 2DQPN89zEFlYPFLo/EhSmd4cTdupogyBVitOAF6sN+FSfkhhRXlNrUtX562BSzXGIcmM aKFFtIBCjTHT2dEMV9F6DpTaoFaKwCVleRKWxWw5laNOnIJ/BDnD66TlXPbZumXTOFAW rLCONezKi+HImLEcHdBEDbeRz12rkjd8brW4XUfylTNVu5/b373NwVGHgUcrXHxDqcce tH3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Le/7zdHVCOzeBmqCe8n6AFtgKj3zkSauBjbRiX3YOG0=; b=ucMV8SU1r0KeB7boF6oId2uVdU/u5sSR2fgBBy4t9T9oHU+NuSanFFDbvSqxlyqp+l wvFxbuY46eQmjn2Qm85GWV2mb7X1SjxK7U04VHdXxFXWNkxlCdiLqtS2hVc7zrQe7p6j Sw3wYKwkm+o0E4sT3DEWVMiMsx0PZ2u4fUYhgRPLueuNL4K8Xzo9CVxCj0ZHiM8c4JvQ dIIG2oIEQv9qCM01dAOSC52UFCx1CwoGsRfeHj325uSGVWdFQ4YemchviJiG/o0Qogfq xvvdd+eT0LQMr8dK9Fz0PlrpioHycRt9A6c4eQ8LLpUVjT/IujsMNqjbX7R+OgWAAUXx sMYQ== X-Gm-Message-State: AGi0PuaZAldBxt4mO7yfheHvEVvYFNqEakVd0Be2eGmxFvihQt3i/uy3 bNYmZ4GfoWAFFSpxUfGiRD75iAJDPcRi7Q== X-Google-Smtp-Source: APiQypJ7FvCAO8kaBGjsxb2cjRdZl9jCUuHUgMH27+XqB1/NkqvE5FzZ7SxWQxwVFSdW5fqWnFg3dg== X-Received: by 2002:a17:902:8c84:: with SMTP id t4mr2227999plo.320.1586791388267; Mon, 13 Apr 2020 08:23:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m28sm8047127pgn.7.2020.04.13.08.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 08:23:08 -0700 (PDT) Date: Mon, 13 Apr 2020 08:23:00 -0700 From: Stephen Hemminger To: alvinx.zhang@intel.com Cc: dev@dpdk.org, xiaolong.ye@intel.com Message-ID: <20200413082300.1c752eeb@hermes.lan> In-Reply-To: <20200413063037.13728-4-alvinx.zhang@intel.com> References: <20200413063037.13728-1-alvinx.zhang@intel.com> <20200413063037.13728-4-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 03/11] net/igc: implement device base ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 13 Apr 2020 14:30:29 +0800 alvinx.zhang@intel.com wrote: > + PMD_DRV_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d", > + pci_dev->addr.domain, > + pci_dev->addr.bus, > + pci_dev->addr.devid, > + pci_dev->addr.function); If you want, there is a standard format for PCI already. Please use that everywhere since it prints in proper hex. PMD_DRV_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT, pci_dev->addr.domain, pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);