From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F22C2BA19 for ; Sun, 19 Apr 2020 03:12:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8B79B21973 for ; Sun, 19 Apr 2020 03:12:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B79B21973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3BA51D55C; Sun, 19 Apr 2020 05:12:27 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 38D151D417 for ; Sun, 19 Apr 2020 05:12:24 +0200 (CEST) IronPort-SDR: Yhq0FiExl2Td/W+GyUCqZifVkQg02hJZ27WRQ5DCKy5C9HGMOODdKDwPH+/h1yyjtuFAtgdRW9 KgNd4sELzJVQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2020 20:12:23 -0700 IronPort-SDR: O9KjL3z7wzKzeudRF6pynCewERiv9hHDcXvZMU3/L0LwY8tWKQeI3m6GUnGVibHlIdjtN8gaGo ckvvmznq+HsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,401,1580803200"; d="scan'208";a="254607068" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 18 Apr 2020 20:12:22 -0700 Date: Sun, 19 Apr 2020 11:08:08 +0800 From: Ye Xiaolong To: "Liu, Yong" Cc: Maxime Coquelin , "Wang, Zhihong" , "dev@dpdk.org" , "Ding, Xuan" Message-ID: <20200419030808.GB62619@intel.com> References: <20200414125555.86601-1-yong.liu@intel.com> <20200415072417.GB33551@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E635351F0@SHSMSX103.ccr.corp.intel.com> <898c34d3-f6fc-9695-3e7e-26221726a741@redhat.com> <86228AFD5BCD8E4EBFD2B90117B5E81E6353CA6F@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E6353CA6F@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/19, Liu, Yong wrote: >Sorry for missed this question. The purpose of change function is to skip device initialization which is not needed in configuration stage. >When features not matched, can just do feature negotiation in configuration stage and do related actions when virtio device start. Thanks for the explanation, then seems we needs to adjust the comment above accordingly. Thanks, Xiaolong > >Regards, >Marvin > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Friday, April 17, 2020 11:18 PM >> To: Liu, Yong ; Ye, Xiaolong >> Cc: Wang, Zhihong ; dev@dpdk.org; Ding, Xuan >> >> Subject: Re: [PATCH] net/virtio: fix crash when device reconnecting >> >> Hi Marvin, >> >> On 4/15/20 9:30 AM, Liu, Yong wrote: >> >> @@ -2120,7 +2119,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) >> >> >> >> /* if request features changed, reinit the device */ >> >> if (req_features != hw->req_guest_features) { >> >> - ret = virtio_init_device(dev, req_features); >> >> + ret = virtio_negotiate_features(hw, req_features); >> > Why do we need to change virtio_init_device to virtio_negotiate_features >> > here? >> >> >> You missed to reply to that question from Xiaolong. >> >> Regards, >> Maxime >