From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEAAC55194 for ; Sun, 26 Apr 2020 16:24:23 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B7716206DD for ; Sun, 26 Apr 2020 16:24:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="n18opq1x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7716206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9DFB1BF78; Sun, 26 Apr 2020 18:24:21 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 5BCAB1BF4F for ; Sun, 26 Apr 2020 18:24:20 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id x26so7393366pgc.10 for ; Sun, 26 Apr 2020 09:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eLNvmNwbUzAUbgGwZ0wenUWH03ZV+/doR3SgluWVJ1Q=; b=n18opq1xg46oyvI3Zvlt/+VL8nbb2NbXViyhWOsN7836oAKURE9gAZ1KZAys+vpz4x K+d6dK8i+QdIvpBTYqMjaxrMrC0y3k8EnCXrfF1jHJDdx9bIcAx8Ac7tVjHwamOHfTjE uvhcdY5WInteyFYc/q2pXCTH/maO2SQXU9KOoVFhX2kgzfRZCJcTLoX3m8hazM0ZsNVC 2IV9yZECaEClwlpSHAVdnLbP/blTWJbiDBg72v1jLY99IbS+Pk5tLt7SnWfYY7yGMD7v YAZWYewm8xS2EIO14JD+sbs0v+fPHdo2jtt4Ot0QFkUZvvs2bKia0GLe5YJjpBtK6Ta3 RG6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eLNvmNwbUzAUbgGwZ0wenUWH03ZV+/doR3SgluWVJ1Q=; b=AQIn4xR2RCwnkLihWRL6iQy/lu9hor2AEy8IRoIzXgb4aNBuLbsojDAGvi7AhFjAxe hC8vVXDlkaW0skF5Io0/gAzQ66uA0RrRlNwL/rrRIuOi9y1iNNNun4cBe2IHYqqbuPK0 KNNf/RAC3c6symVJPctqg8HShPrQys+QL71lIhqLtGjIx9B0a3pJs/fbw0qTF1Ot5A79 n0WKJnohy9h/xwl8+iTa/pWFSKDQvHMNduM1aC95hJSuVhPHmkWyM7oNPLEccNSRH1zf JSymNEBsj8/RRXXPmPXtpSBhjQhnpuMyywDVqMcAgU9ioNt/mpUgNbvBI8XtKzkVqeLI tYSA== X-Gm-Message-State: AGi0PuZIxvDS4vOaNft5ggOKUQ6VKgULqYkhoDmkpzCd+hSQKTKx64so e7FLHzBb+Ja2cAYM6oSd/yMrmg== X-Google-Smtp-Source: APiQypINNs4wpdfOUfP8vGJnToQPnpGsFInalV0fGE6H0vK5KcVivhUxSMHXkmVDgEB8nze+S8Iv/A== X-Received: by 2002:a62:4e88:: with SMTP id c130mr20245055pfb.122.1587918259363; Sun, 26 Apr 2020 09:24:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l1sm6307794pgn.66.2020.04.26.09.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2020 09:24:19 -0700 (PDT) Date: Sun, 26 Apr 2020 09:24:10 -0700 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20200426092410.3703114d@hermes.lan> In-Reply-To: References: <20200104013341.19809-1-stephen@networkplumber.org> <20200104013341.19809-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/14] eal: intr: cleanup resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 25 Apr 2020 18:49:23 +0200 David Marchand wrote: > > > > +void > > +rte_eal_intr_cleanup(void) > > +{ > > + pthread_cancel(intr_thread); > > + pthread_join(intr_thread, NULL); > > + close(intr_pipe.readfd); > > + close(intr_pipe.writefd); > > What happens to the intr_sources callbacks? > I am unsure we can expect the application to clean this before the eal cleanup. > > It would be worth a followup patch. The callbacks should be not run after cleanup. The goal was to cleanup outstanding system resources (as reported by valgrind) on eal_cleanup