From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190F2C433E1 for ; Wed, 8 Jul 2020 10:22:38 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AAF51206F6 for ; Wed, 8 Jul 2020 10:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U9GfW+9B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAF51206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A45411DAF4; Wed, 8 Jul 2020 12:22:36 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id AE7EA1D452 for ; Wed, 8 Jul 2020 12:22:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594203754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pg8QZJXwwICXpdkzg0pgwqnyT8GKDeK2YYFwWo/OLJI=; b=U9GfW+9BWFXicKWNYW4uEY80/7R51RiHnhuLbjm3R521JcJvrfITKlt15l7POHdEgHkL5Q vWsqazk660mkShAAl47fHsMnm4KrLZsewkRE/cs7D/9x0HCGq7goPV2NWOUQfOGmBOhTPb 9unV7MgTo7WAiE0Xljf6vSmQ+OnXwRM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-5qznnkWsOw2Wt9X-Y8Vh8g-1; Wed, 08 Jul 2020 06:22:33 -0400 X-MC-Unique: 5qznnkWsOw2Wt9X-Y8Vh8g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98875108B; Wed, 8 Jul 2020 10:22:31 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF8975C57D; Wed, 8 Jul 2020 10:22:17 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, dodji@redhat.com, Ray Kinsella , Neil Horman Date: Wed, 8 Jul 2020 12:22:12 +0200 Message-Id: <20200708102212.3311-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" abidiff can provide some more information about the ABI difference it detected. In all cases, a discussion on the mailing must happen but we can give some hints to know if this is a problem with the script calling abidiff, a potential ABI breakage or an unambiguous ABI breakage. Signed-off-by: David Marchand --- devtools/check-abi.sh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index e17fedbd9f..521e2cce7c 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do error=1 continue fi - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { + abiret=$? echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" error=1 - fi + echo + if [ $(($abiret & 3)) != 0 ]; then + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org." + fi + if [ $(($abiret & 4)) != 0 ]; then + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." + fi + if [ $(($abiret & 8)) != 0 ]; then + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." + fi + echo + } done [ -z "$error" ] || [ -n "$warnonly" ] -- 2.23.0