From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6D4C433E1 for ; Thu, 9 Jul 2020 08:17:58 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id F1A1E2070E for ; Thu, 9 Jul 2020 08:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LwiJCOTr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1A1E2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D73011DD79; Thu, 9 Jul 2020 10:15:21 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0ED401DD0C for ; Thu, 9 Jul 2020 10:15:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594282519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cmOCrnN5iogF17mST0M9DEsHrmKNgQGGnXEYAdaFFJQ=; b=LwiJCOTr6S7HtODPFi+uoOzkBOqhftX06cCvodw7kdvNxPtrfWyA0th875NvPSkJPRmEVL 9bgWnZeHoRWo27ksRSKdLaQ0b5C+MQTEiBLjQFtFjt0dcUd1cg96y+gQ3buapOUYypfKaM bfFciCXHTC2OOUj0t2inFXHkqt3yINQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-Sn-7DxYbMsCXqXb4BflMuA-1; Thu, 09 Jul 2020 04:15:15 -0400 X-MC-Unique: Sn-7DxYbMsCXqXb4BflMuA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51FCD18FF662; Thu, 9 Jul 2020 08:15:14 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78F6F6FED4; Thu, 9 Jul 2020 08:15:11 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net, Ajit Khaparde , Somnath Kotur , Randy Schacher , Venkat Duvvuru , Peter Spreadborough Date: Thu, 9 Jul 2020 10:15:04 +0200 Message-Id: <20200709081504.12336-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/bnxt: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. Testing against a n value does not work and we end up with a link issue: /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc': .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference to `tf_em_ext_alloc' /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free': .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference to `tf_em_ext_free' collect2: error: ld returned 1 exit status gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3] Error 1 gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") Signed-off-by: David Marchand --- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/tf_core/Makefile b/drivers/net/bnxt/tf_core/Makefile index b4fbdd00fc..806471427c 100644 --- a/drivers/net/bnxt/tf_core/Makefile +++ b/drivers/net/bnxt/tf_core/Makefile @@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c -- 2.23.0