From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ECAC433E2 for ; Wed, 2 Sep 2020 09:55:17 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3F4652084C for ; Wed, 2 Sep 2020 09:55:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F4652084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9297C1C069; Wed, 2 Sep 2020 11:55:16 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C5E2FCF3 for ; Wed, 2 Sep 2020 11:55:14 +0200 (CEST) IronPort-SDR: iAfaxvjI0cIIzSw2+d3t4POYjZtKpW3i0ovnN3fGkyKpJm45i2vQroyBCNhnAUJO0ooH/GlkAl VaTx+z2Momqg== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="158352354" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="158352354" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 02:55:11 -0700 IronPort-SDR: VF1wVO9z4OIyTX5UMLtvHNxwcme6kl+J/c6aLBQn1KuLOlsp2pAEDPPtyk9G4B7C63OWS0wtEw TfehUyuCUzmA== X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="477573396" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.68]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Sep 2020 02:55:10 -0700 Date: Wed, 2 Sep 2020 10:55:07 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20200902095507.GA1064@bricha3-MOBL.ger.corp.intel.com> References: <2173565.OSGeAx7z5R@thomas> <20200901165643.15668-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901165643.15668-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] usertools: add huge page setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 01, 2020 at 09:56:43AM -0700, Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. Differences are: > * it autodetects NUMA vs non NUMA > * it allows setting different page sizes > recent kernels support multiple sizes. > * it accepts a parameter in bytes (not pages). > > Signed-off-by: Stephen Hemminger > --- > This is lightly tested, it still needs testing on multiple architectures > etc. > > usertools/hugepage-setup.sh | 169 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 169 insertions(+) > create mode 100755 usertools/hugepage-setup.sh > > diff --git a/usertools/hugepage-setup.sh b/usertools/hugepage-setup.sh > new file mode 100755 > index 000000000000..df132e2f8d64 > --- /dev/null > +++ b/usertools/hugepage-setup.sh > @@ -0,0 +1,169 @@ > +#! /bin/bash Is there a good reason to limit this to bash rather than general "sh"? Also, if we ever see this script being expanded to cover more, would it be more extensible in python rather than shell?