From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C73C433E2 for ; Thu, 3 Sep 2020 09:21:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 07F9B206C0 for ; Thu, 3 Sep 2020 09:21:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07F9B206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 434B61C0AF; Thu, 3 Sep 2020 11:21:02 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1DDEDE07 for ; Thu, 3 Sep 2020 11:21:00 +0200 (CEST) IronPort-SDR: R8K1gDY+1ZzjF3GNsEV3N9UPrZYiE/bGTtmbhfV/VMDsbv1FV8svZKwX1UOexhXMcMSN5JEM8v 4pcHImGfsJDw== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="137596177" X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="137596177" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 02:21:00 -0700 IronPort-SDR: FPrKxHWFYMH5txNY1Ct6coTNGjv0MhjSgG/3jktSMVmS9ReIhrxraX/WYWZv6iDiLs0YiaNOzA /nP4owFb1buQ== X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="477985155" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.168]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Sep 2020 02:20:56 -0700 Date: Thu, 3 Sep 2020 10:20:52 +0100 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org, Jie Zhou , Ranjit Menon , Olivier Matz , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Marko Kovacevic , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , Cristian Dumitrescu , Jasvinder Singh , Maxime Coquelin , Chenbo Xia , Zhihong Wang , David Hunt Message-ID: <20200903092052.GA1615@bricha3-MOBL.ger.corp.intel.com> References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> <20200902183805.5421-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902183805.5421-1-dmitry.kozliuk@gmail.com> Subject: Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > cmdline_numtype member names clash with Windows system identifiers. > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > future conflicts. > > Signed-off-by: Dmitry Kozlyuk > Suggested-by: Ranjit Menon > --- Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_ as a prefix. This is one I suggested previously (over a year ago, actually): http://patches.dpdk.org/patch/52644/ /Bruce