From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA21C4363A for ; Mon, 5 Oct 2020 10:19:14 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B67142078D for ; Mon, 5 Oct 2020 10:19:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B67142078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=u256.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A13581B62B; Mon, 5 Oct 2020 12:19:11 +0200 (CEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by dpdk.org (Postfix) with ESMTP id 460712BE6 for ; Mon, 5 Oct 2020 12:19:10 +0200 (CEST) X-Originating-IP: 86.254.165.59 Received: from u256.net (lfbn-poi-1-843-59.w86-254.abo.wanadoo.fr [86.254.165.59]) (Authenticated sender: grive@u256.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0EED720008; Mon, 5 Oct 2020 10:19:07 +0000 (UTC) Date: Mon, 5 Oct 2020 12:19:02 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, Anatoly Burakov Message-ID: <20201005101844.calrhrazj5j2mwv2@u256.net> References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-12-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200928231437.414489-12-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v3 11/29] net/failsafe: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 29/09/20 01:14 +0200, Thomas Monjalon wrote: > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > can be freed by rte_eth_dev_close(). > > Freeing of private port resources is moved > from the ".remove(device)" to the ".dev_close(port)" operation. > > Signed-off-by: Thomas Monjalon Thanks for doing this. LGTM: Acked-by: Gaetan Rivet -- Gaƫtan