From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C10C433E7 for ; Fri, 16 Oct 2020 15:52:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3F0FD20848 for ; Fri, 16 Oct 2020 15:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F0FD20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0FB11EA85; Fri, 16 Oct 2020 17:52:23 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E91E01E91E for ; Fri, 16 Oct 2020 17:52:20 +0200 (CEST) IronPort-SDR: GweJMW1nNfrUPiAekHfBFMAjkhz6dTb2mpA0bD+WWHqwUyi86eJ6VnaF4cQTuiXhCmMynrl1wI /2f3TGZ/Ez6w== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="166709502" X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="166709502" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 08:52:19 -0700 IronPort-SDR: +wsDQgKQhcqsElGuW3pReY/nuUEmi3H02m5goFCVSs2eq8b0YamasWtVZIkv5VSOs7MrmacMe0 EdPEEgixYAFg== X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="464718119" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.54.208]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Oct 2020 08:52:17 -0700 Date: Fri, 16 Oct 2020 16:52:13 +0100 From: Bruce Richardson To: "Kinsella, Ray" Cc: David Marchand , dev , Thomas Monjalon , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Konstantin Ananyev , Kevin Traynor Message-ID: <20201016155213.GA1121@bricha3-MOBL.ger.corp.intel.com> References: <20201016093806.20061-1-david.marchand@redhat.com> <20201016102711.11926-1-david.marchand@redhat.com> <7f7c1ac8-947f-40d1-bf21-4e13c196ec72@ashroe.eu> <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu> Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 04:48:59PM +0100, Kinsella, Ray wrote: > > On 16/10/2020 12:22, David Marchand wrote: > > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: > >> > >> > >> The windows exports and the map files, feels like duplication of effort. > >> Could we massage one into the other during the build? > > > > That's what is done with map-to-win.py, unless we have one exception > > when the full library is not ready, like EAL. > > > > https://git.dpdk.org/dpdk/tree/lib/meson.build#n152 > > https://git.dpdk.org/dpdk/tree/buildtools/map_to_win.py#n27 > > > > Thinking about this again - future work might be to check if a .def exists. > And then to warn in checkpatch if one is modified without the other? > Possibly, but right now there is only the one .def override file, for EAL, and a better use of effort is to close the gap between windows and other versions so that it can be removed completely. $ find lib/ drivers/ -name *.def lib/librte_eal/rte_eal_exports.def /Bruce