From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68C8C2D0E4 for ; Sun, 15 Nov 2020 11:24:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B0CEF223C7 for ; Sun, 15 Nov 2020 11:24:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="cgle88zJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0CEF223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EE76493D; Sun, 15 Nov 2020 12:24:02 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 362C0323E for ; Sun, 15 Nov 2020 12:24:00 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 15 Nov 2020 03:24:02 -0800 Received: from nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 15 Nov 2020 11:23:54 +0000 From: Gregory Etelson To: CC: , , , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger Date: Sun, 15 Nov 2020 13:23:40 +0200 Message-ID: <20201115112341.30617-1-getelson@nvidia.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605439442; bh=Nv8gfDF7/5CtaEKJqQaU7gptvDgeWfpbtncndjDrAkA=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=cgle88zJrR31B1VXynqvS4Fi/q2SGJAmf9YYVWc14eRXd2rpGfoi0rK/bYdyfv4Xd 2Hv6/QnqnAfA1Ah6ST1BJmn/OO1VUsOZwg/G8SMCtF0jTKvD8EuFmxF/G5cCRVPEh4 iMSg5Qp3t+NjyWiReHk2el7NHAgUkWukA1k/42UWUHF9DWsnXs5b6cwhYBfjdDGEK7 rCdMFzxEdEZXvFJZS3fIaqZxkiU3z0kcCM0jhiGPj5g0UYBORSA0qxip9Nkc+5CqA3 7dG4HcdFIJpej89BqeF9BWEb6/SdByzxwyf+APUC8Wmkc0RFE5cvCjmOEvFkof78u0 5+I195tq526RQ== Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow tunnel create command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" testpmd provides commands to test tunnel offload rte_flow capabilities. A command that creates a tunnel had a syntax bug that allowed to spesify the 'create' command part several times. Current patch fixed that fault. Correct syntax for tunnel cretion is: testpmd> flow tunnel create type Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 457f74078d..bf00ba0acb 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -812,8 +812,7 @@ static const enum index next_vc_attr[] =3D { ZERO, }; =20 -static const enum index tunnel_create_attr[] =3D { - TUNNEL_CREATE, +static const enum index tunnel_create_type_attr[] =3D { TUNNEL_CREATE_TYPE, END, ZERO, @@ -2009,14 +2008,15 @@ static const struct token token_list[] =3D { [TUNNEL_CREATE] =3D { .name =3D "create", .help =3D "create new tunnel object", - .next =3D NEXT(tunnel_create_attr, NEXT_ENTRY(PORT_ID)), + .next =3D NEXT(NEXT_ENTRY(TUNNEL_CREATE_TYPE), + NEXT_ENTRY(PORT_ID)), .args =3D ARGS(ARGS_ENTRY(struct buffer, port)), .call =3D parse_tunnel, }, [TUNNEL_CREATE_TYPE] =3D { .name =3D "type", .help =3D "create new tunnel", - .next =3D NEXT(tunnel_create_attr, NEXT_ENTRY(FILE_PATH)), + .next =3D NEXT(tunnel_create_type_attr, NEXT_ENTRY(FILE_PATH)), .args =3D ARGS(ARGS_ENTRY(struct tunnel_ops, type)), .call =3D parse_tunnel, }, --=20 2.29.2