From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B922DC433E0 for ; Tue, 22 Dec 2020 08:16:32 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5FCDE23137 for ; Tue, 22 Dec 2020 08:16:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FCDE23137 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E0EBCA74; Tue, 22 Dec 2020 09:16:30 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AFBD8CA6A for ; Tue, 22 Dec 2020 09:16:27 +0100 (CET) IronPort-SDR: eQ5K6C7oavxwWZQNRoBj2kWpHY1wviygUWwD7bnKnLGwtEzEMfK0eo8UPgx4BqA3sGhiWf7weK kV/ZAQLfWISA== X-IronPort-AV: E=McAfee;i="6000,8403,9842"; a="237399248" X-IronPort-AV: E=Sophos;i="5.78,438,1599548400"; d="scan'208";a="237399248" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 00:16:26 -0800 IronPort-SDR: jv9PZiTS81H9DlX5oTnKLnDf39XhOfpsazv0zBKWPVaaz+/rCTvNg1Rhu0YrWF6FbURAJ1ycoz Vvj06jMTsHsQ== X-IronPort-AV: E=Sophos;i="5.78,438,1599548400"; d="scan'208";a="373192766" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 00:16:24 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, Steve Yang Date: Tue, 22 Dec 2020 08:13:35 +0000 Message-Id: <20201222081335.17419-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-pkt-len X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When 'max-pkt-len' value caused the 'rx_offloads' flag change, the all offloads of rx queues ('rx_conf[qid].offloads') weren't synchronized, that will cause the offloads check failed with 'rx_queue_offload_capa' within 'rte_eth_rx_queue_setup'. Apply rx offloads configuration once it changed when 'max-pkt-len' command parsed. Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") Signed-off-by: Steve Yang --- app/test-pmd/cmdline.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 2ccbaa039e..d72a40d7de 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1902,7 +1902,23 @@ cmd_config_max_pkt_len_parsed(void *parsed_result, rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; else rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; - port->dev_conf.rxmode.offloads = rx_offloads; + + if (rx_offloads != port->dev_conf.rxmode.offloads) { + uint16_t k; + int ret; + + port->dev_conf.rxmode.offloads = rx_offloads; + /* Apply Rx offloads configuration */ + ret = eth_dev_info_get_print_err(pid, + &port->dev_info); + if (ret != 0) + rte_exit(EXIT_FAILURE, + "rte_eth_dev_info_get() failed\n"); + + for (k = 0; + k < port->dev_info.nb_rx_queues; k++) + port->rx_conf[k].offloads = rx_offloads; + } } else { printf("Unknown parameter\n"); return; -- 2.17.1