From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] ip_pipeline: add Python script file
	for	creating visual diagram of IP pipeline config file
Date: Mon, 11 Jul 2016 17:29:57 +0200
Message-ID: <2020300.RGHe2OjfZK@xps13>
References: <1466704213-127847-1-git-send-email-jasvinder.singh@intel.com>
 <1467130945-130512-1-git-send-email-jasvinder.singh@intel.com>
 <B27915DBBA3421428155699D51E4CFE2025885B5@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>, "Dumitrescu,
 Cristian" <cristian.dumitrescu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id BCA3F3F9
 for <dev@dpdk.org>; Mon, 11 Jul 2016 17:30:02 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id i5so22557520wmg.0
 for <dev@dpdk.org>; Mon, 11 Jul 2016 08:30:02 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025885B5@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > This commit adds Python script for generating diagram of the application
> > configuration file. This script requires graphviz package to be installed
> > on the machine. The input config file is translated to an output file in
> > DOT syntax, which is then used to create the image file using graphviz.
> > 
> > To run the script, following command is used;
> > 
> > ./diagram-generator.py -f <input configuration file>
> > 
> > Some optional arguments are as follows:
> >   -h, --help            show this help message and exit
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> 
> The subject line is too long:
> 
>     $ scripts/check-git-log.sh 
>     Headline too long:
>         ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file
> 
> I would suggest something like:
> 
>         ip_pipeline: add script for creating config diagrams

or
	examples/ip_pipeline: add config diagram generator

> The code looks good though, so:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

This example become more and more complex...