From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2148FC433DB for ; Mon, 25 Jan 2021 08:35:31 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 79A6C22CAD for ; Mon, 25 Jan 2021 08:35:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79A6C22CAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F512140D95; Mon, 25 Jan 2021 09:35:29 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6C167140D5C for ; Mon, 25 Jan 2021 09:35:27 +0100 (CET) IronPort-SDR: qIVAyb2Dk6SKiGpuqXVW0JzwBdnP4k9epFHmCv9wJQKNZMqKanGQYDKemIVU1iEy6SjUsbt9JT EWYoJgy81UaQ== X-IronPort-AV: E=McAfee;i="6000,8403,9874"; a="241220732" X-IronPort-AV: E=Sophos;i="5.79,373,1602572400"; d="scan'208";a="241220732" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2021 00:35:26 -0800 IronPort-SDR: tqw/pkxbGw78dA7ybFqn/GsdDvfvQ8clgKgMoeMC4dW85Xh5vj3zvkIwV2Eqe1b0I48O3cJriZ /B2nRoqJUvYw== X-IronPort-AV: E=Sophos;i="5.79,373,1602572400"; d="scan'208";a="361281574" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2021 00:35:19 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, qiming.yang@intel.com, Steve Yang Date: Mon, 25 Jan 2021 08:32:00 +0000 Message-Id: <20210125083202.38267-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210122090110.50453-1-stevex.yang@intel.com> References: <20210122090110.50453-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v4 0/2] fix 'max-pkt-len' errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Here fixed 3 issues for 'max-pkt-len': 1. When cmdline option '--max-pkt-len' set the value less then '1500 + overhead', the app/testpmd will force to resize the 'max-pkt-len' to '1500 + overhead'. However, the user really want to configure 'max-pkt-len' to a specified value (< 1500 + overhead); 2. If the large value of '--max-pkt-len' gave (e.g.: 8000), and user want to reset the value to a small one (e.g.: 1400), it will became invalid due to JUMBO_FRAME offload state doesn't change before port started; 3. When rx/tx queue offloads capabilities aren't specified, the rx/tx queue setup will be failed once the port offloads changed. --- v4: * combined testpmd patches; * updated the commit log for patch 2; v3: * rebased code to latest; * splited to 3 commits; v2: * moved the update logic to 'rxtx_port_config'; * added the 'tx_conf' part; * optimized the 'default' assignment; --- Steve Yang (2): ethdev: fix MTU doesn't update when jumbo frame disabled app/testpmd: fix max-pkt-len option invalid app/test-pmd/cmdline.c | 1 + app/test-pmd/parameters.c | 1 + app/test-pmd/testpmd.c | 63 +++++++++++++++++++++++++--------- app/test-pmd/testpmd.h | 2 ++ lib/librte_ethdev/rte_ethdev.c | 8 ++--- 5 files changed, 54 insertions(+), 21 deletions(-) -- 2.17.1