From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DB8C433E0 for ; Fri, 5 Feb 2021 21:24:09 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 8484864D79 for ; Fri, 5 Feb 2021 21:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8484864D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7635240682; Fri, 5 Feb 2021 22:24:07 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id C99EC4067B; Fri, 5 Feb 2021 22:24:05 +0100 (CET) IronPort-SDR: X23BYzEnqYrFMstnR/VA4qlnGy3qIGaAQef7F2DnUkOccWmJ1Rfq6ftWJlo+Sb6sq8jxK/upic XB43VMLJPsvg== X-IronPort-AV: E=McAfee;i="6000,8403,9886"; a="180714387" X-IronPort-AV: E=Sophos;i="5.81,156,1610438400"; d="scan'208";a="180714387" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 13:24:04 -0800 IronPort-SDR: 9lnBH+/GNXY6ElOLqNaa/Q6v5wtxVv+qa3t1UC6KAbvJjCwgqgIAVisRpEz9Dn+PvTPTNBp516 V4/V6XWGamEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,156,1610438400"; d="scan'208";a="373691154" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by fmsmga008.fm.intel.com with ESMTP; 05 Feb 2021 13:24:02 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, Bruce Richardson , stable@dpdk.org Date: Fri, 5 Feb 2021 21:23:57 +0000 Message-Id: <20210205212358.413871-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] telemetry: mark init function as internal-only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The "rte_telemetry_init()" function is for use by "rte_eal_init()" and should not be part of the public API. Mark it as internal only. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_21_02.rst | 5 +++++ lib/librte_telemetry/rte_telemetry.h | 2 +- lib/librte_telemetry/version.map | 5 ++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index baf32151f..84b04a018 100644 --- a/doc/guides/rel_notes/release_21_02.rst +++ b/doc/guides/rel_notes/release_21_02.rst @@ -266,6 +266,11 @@ ABI Changes * No ABI change that would break compatibility with 20.11. +* The experimental function ``rte_telemetry_init`` has been removed from the + public API and is now an internal-only function. Where telemetry library is + available, it is called automatically from ``rte_eal_init()`` and so no end + application need use it. + Known Issues ------------ diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h index f6c3992a9..f7c8534b8 100644 --- a/lib/librte_telemetry/rte_telemetry.h +++ b/lib/librte_telemetry/rte_telemetry.h @@ -309,7 +309,7 @@ rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help); * @return * -1 on failure. */ -__rte_experimental +__rte_internal int rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, const char **err_str); diff --git a/lib/librte_telemetry/version.map b/lib/librte_telemetry/version.map index d1dbf8d58..ec0ebc1be 100644 --- a/lib/librte_telemetry/version.map +++ b/lib/librte_telemetry/version.map @@ -14,9 +14,12 @@ EXPERIMENTAL { rte_tel_data_start_array; rte_tel_data_start_dict; rte_tel_data_string; - rte_telemetry_init; rte_telemetry_legacy_register; rte_telemetry_register_cmd; local: *; }; + +INTERNAL { + rte_telemetry_init; +}; -- 2.27.0