From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0693EC433DB for ; Fri, 19 Mar 2021 07:11:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 7B5B164F69 for ; Fri, 19 Mar 2021 07:11:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B5B164F69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E87740143; Fri, 19 Mar 2021 08:11:32 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3DC934003F; Fri, 19 Mar 2021 08:11:29 +0100 (CET) IronPort-SDR: tOFh6I/zJPuvHjs2PGadiM8//jRuvykCHWdYDKttcTxz1FyHcAYoTWiazpOHRIOhCd/hOUxBGD U7kV1dmI2Dgg== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="176974896" X-IronPort-AV: E=Sophos;i="5.81,261,1610438400"; d="scan'208";a="176974896" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2021 00:11:28 -0700 IronPort-SDR: dWeoVs68y6DhE4LA+ITo1dpc0aMZPAcDFLmBYY6ekCQ55PPGcknk6XfU/5fytjxXW+ftbpAMK8 S2CliCT+jeoQ== X-IronPort-AV: E=Sophos;i="5.81,261,1610438400"; d="scan'208";a="413406281" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2021 00:11:26 -0700 From: dapengx.yu@intel.com To: reshma.pattan@intel.com Cc: dev@dpdk.org, Dapeng Yu , shahafs@mellanox.com, stable@dpdk.org Date: Fri, 19 Mar 2021 15:11:18 +0800 Message-Id: <20210319071118.945615-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210311063654.233157-1-dapengx.yu@intel.com> References: <20210311063654.233157-1-dapengx.yu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] examples/packet_ordering: use local port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dapeng Yu A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be enabled on port. This patch use this local variable as input of rte_eth_dev_configure(). Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API") Cc: shahafs@mellanox.com Cc: stable@dpdk.org Signed-off-by: Dapeng Yu Acked-by: Reshma Pattan --- v2: * Add Cc: and Acked-by: examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index 4bea1982d..963b11d6d 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id) if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; - ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default); + ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf); if (ret != 0) return ret; -- 2.27.0