From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935ECC433C1 for ; Wed, 24 Mar 2021 22:41:52 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 03902619E4 for ; Wed, 24 Mar 2021 22:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03902619E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E149F4067B; Wed, 24 Mar 2021 23:41:50 +0100 (CET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id ED76F4014F for ; Wed, 24 Mar 2021 23:41:48 +0100 (CET) Received: by mail-lj1-f178.google.com with SMTP id 15so742927ljj.0 for ; Wed, 24 Mar 2021 15:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ptzTEfwMd+BPyfRsdsVehKD2W8w5OGkGE/PSgGG5+U=; b=K9gOMtw7DiJkUOJCHHhgXmxmpaSwMOMCux8ylnPsoPK+B1lJk0dQ9LIydQUDlobVo6 ByMfBVIkw4RHEohXUA2sJEzXJfwgI+xPJJoDeKfT7z6vZZX1bchCevDewNFetH00ePA7 ZWDNqvmucO74Riz3XoaMYtiMCx+rSwOu1vzHzXWJ5WlJR4LjQg3MQDoTBkUU8o76yaGK hPzHhNFCqGLrUQVVebCaJWFNBhnqkw132x1M2TLB60cjwdQYHL3GEb5zuJD7Gk12Ondr KzcxxBjYXgNVkm/QOfDZmTkd1A6qvzcKrtjOqAwgRad1hQLp+9w271Kdxj40np8jS6vz YY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ptzTEfwMd+BPyfRsdsVehKD2W8w5OGkGE/PSgGG5+U=; b=iewl3v+/p8id3t2Wt8qlDveavFSolCWK7yv6Nen34lWWIljFyTvs092oW237Bw50t0 x9W8I4t7swjtfUfizi93aQqL2IiErEvcUp2J7GDTkrhDqALJ08ccdwUXmgUaTaOc1Ecb samm18otbYchbhYWpf+1fnJkUzPPmMGJzy/1aNbXR5UHvm1Dn5e2SGrEn6ZCKZTT4uQf YauSg3C67T6jg+aT2axZI1aqjzgz+3txIkdijuLraZCYmKzSvn0WOvM8Kn3yuUKVsb/c MxETqEBpq5ThWqZLvHCsWosLY69crKVWLTN8vUTPBH+KhksnSJpHiXT4FlqYtnPwTapQ XP6g== X-Gm-Message-State: AOAM533qhvfW7op/q9wX/IBBJQ7KGdkgyx8/WRFvlzC7xfDDtzdX08ac JBJf9Vu1DD5harrAxIZjhrE= X-Google-Smtp-Source: ABdhPJyJZ5i2gfUevJXbADKQ8bULbG+Cz8dzJM6BdvpllkE95cA51hcgAiyaFuzVfkVCL9xil6PRNQ== X-Received: by 2002:a2e:98d2:: with SMTP id s18mr3369441ljj.412.1616625708509; Wed, 24 Mar 2021 15:41:48 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v11sm481488ljp.63.2021.03.24.15.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 15:41:48 -0700 (PDT) Date: Thu, 25 Mar 2021 01:41:47 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: Thomas Monjalon , dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stephen@networkplumber.org, drc@linux.vnet.ibm.com Message-ID: <20210325014147.2a2f5749@sovereign> In-Reply-To: <20210324215548.GA2272@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <6578330.zVv2phWGOd@thomas> <20210324172841.GC14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <11634428.8dEGKDZn2b@thomas> <20210324215548.GA2272@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > On Wed, Mar 24, 2021 at 06:52:40PM +0100, Thomas Monjalon wrote: > > 24/03/2021 18:28, Tyler Retzlaff: [...] > > > would you prefer that i change the preprocessor protection to include only > > > windows? since i'm certain that this will break for any c++ compiler on > > > windows the moment any stl header is included. > > > > No, C++ is probably the right scope. > > > > I don't know yet. I would like to understand the global picture, > > and have it properly documented in this commit log. > > yep, no problem. i suspect we are probably the only ones using c++ and > dpdk (though others can speak up if they do too) which may be why this > has gone unnoticed until now. You're certainly not the only one: * Seastar is a C++ userspace TCP/IP stack, ScyllaDB is based on it. * Click modular router can use DPDK from C++ [1]. * DPDK-based product out company works on is in C++. Can't speak for Seastar and Click, but we never hit this particular issue. What is the minimal complete example to reproduce? [1]: https://github.com/kohler/click/blob/master/elements/userlevel/fromdpdkdevice.cc