From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCA2C433B4 for ; Thu, 1 Apr 2021 14:10:13 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6FBA36128B for ; Thu, 1 Apr 2021 14:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FBA36128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C03614131C; Thu, 1 Apr 2021 16:10:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 58C131412BA for ; Thu, 1 Apr 2021 16:10:11 +0200 (CEST) IronPort-SDR: Xrb322lgCBcN7GacDIqpCcur9gWP/1YkojveS/csdefy6FaEDTbw0CYqxxE2UbWs85KX2/10+S t7fGUPJVXq+w== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="191730477" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="191730477" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:10:09 -0700 IronPort-SDR: pFsGoX2XXuiRB9tQy+rIzck3f0NSiApcjeKLREeXHz5GIy7Qx05DuPLhTViR7Zwtc2LT5h9GIV HigCsEsjKE4Q== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377715408" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.228]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Apr 2021 07:10:08 -0700 Date: Thu, 1 Apr 2021 15:10:04 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, bluca@debian.org Message-ID: <20210401141004.GE1627@bricha3-MOBL.ger.corp.intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> <6494687.Qfmhli7XZA@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6494687.Qfmhli7XZA@thomas> Subject: Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 03:36:39PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:49, Bruce Richardson: > > This RFC contains 5 changes/updates to the DPDK build and build files. These > > updates all assume that the minimum version for DPDK has increased to at least > > meson 0.49 as proposed in [1]. > > > > The changes in this set are: > > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels > > in the foreach loops when building library or driver components. > > 2. For libraries, drop support for header-only libraries, which was added just > > for the "compat" lib which had a single header, and is now part of EAL. This > > similarly reduces indentation levels and makes the code easier to follow > > 3. Since the larger blocks of meson code in our repo is seeing massive > > whitespace changes, take the opportunity to switch our indentation style for > > meson files from that of C-files using tabs, to Meson/Python style using > > spaces. [More below on this for discussion] > > 4. Remove the "librte_" prefix from all our library directories. While as useful > > cleanup, the main driver for this was that it simplifies the matching for #5 > > below. > > 5. Add a "disable_libs" build option to allow the user to optionally not build > > certain components. Include in this an explicit list of libraries which are > > "known safe" to disable in the build. For now this is a short list of three > > libs, all of which are safe because they are not buildable on FreeBSD. More > > work is needed to expand this list in future. > > > > Of these changes, I expect #3 to be most controversial. > > Did you choose April 1st on purpose? > It kinda just happened that way. This patchset has been in the works for some time, but never got to an RFC point before now. And what with more serious things, I never got the opportunity to prepare a *proper* April 1st patchset. :-)