From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331C8C433ED for ; Wed, 12 May 2021 08:18:22 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6E034613F3 for ; Wed, 12 May 2021 08:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E034613F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B0784003F; Wed, 12 May 2021 10:18:20 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9BA304003E; Wed, 12 May 2021 10:18:18 +0200 (CEST) IronPort-SDR: I2r7IXLBCQ81CZy5aKw/G4R9O2ZG1upQsOzSeE8XRhEosD683uCTYraJM0tqCxw9dXlsaNWeVk JZooxAQq2G5w== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="220618705" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="220618705" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 01:18:11 -0700 IronPort-SDR: otEZIr1H0DpJuhxVukmQ2JtreYsprRU6sHVCppallKYZTbcKZkS8TbbvVaDAhAB5Fdl06L+/DD mPlCi48dc8Kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="392629798" Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.150]) by orsmga006.jf.intel.com with ESMTP; 12 May 2021 01:18:09 -0700 From: beilei.xing@intel.com To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Beilei Xing , stable@dpdk.org Date: Wed, 12 May 2021 16:04:00 +0800 Message-Id: <20210512080400.103225-1-beilei.xing@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/iavf: fix wrong Tx context descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 20210512070646.102006-1-beilei.xing@intel.com Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Beilei Xing The QW0 of Tx context descriptor should be reset to 0, otherwise the previous hardware writeback value may pollute the next context descriptor write. Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") Cc: stable@dpdk.org Signed-off-by: Qi Zhang Signed-off-by: Beilei Xing --- v2 change: - Typo fix. drivers/net/iavf/iavf_rxtx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 74b5ab5bde..6a713df828 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -2245,6 +2245,11 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) (volatile struct iavf_tx_context_desc *) &txr[tx_id]; + /* clear QW0 or the previous writeback value + * may impact next write + */ + *(volatile uint64_t *)ctx_txd = 0; + txn = &sw_ring[txe->next_id]; RTE_MBUF_PREFETCH_TO_FREE(txn->mbuf); if (txe->mbuf) { -- 2.26.2