From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1BAC4708F for ; Wed, 2 Jun 2021 08:17:54 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id AEF1A6100A for ; Wed, 2 Jun 2021 08:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEF1A6100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92B0A4069F; Wed, 2 Jun 2021 10:17:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0873540689; Wed, 2 Jun 2021 10:17:49 +0200 (CEST) IronPort-SDR: a9Xr5TBwMqFG2/kVChpE+ZRpGswKi/MIcKePVa+5JHFshNyJjzbFeQIWlogWtPEcJDZNVfjY6e JfzfYzNgdM5A== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="203730430" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="203730430" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 01:17:48 -0700 IronPort-SDR: eYGe3Rcp/nVfiZAzkMy0C7fnZ95+JsXB6O6pJ63UYVqZTyBLg3KaEdCFiZA7e4H48Y96j1qO2g n3WQBbNNMJUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="479619529" Received: from dpdk-xuting-second.sh.intel.com ([10.67.116.193]) by orsmga001.jf.intel.com with ESMTP; 02 Jun 2021 01:17:46 -0700 From: Ting Xu To: dev@dpdk.org Cc: qi.z.zhang@intel.com, qiming.yang@intel.com, Ting Xu , stable@dpdk.org Date: Wed, 2 Jun 2021 16:21:04 +0800 Message-Id: <20210602082104.33681-1-ting.xu@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When creating FDIR rule and parsing the pattern, if IPv4 fragment type is detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with other FDIR rules for IPv4 other type. Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet") Cc: stable@dpdk.org Signed-off-by: Ting Xu --- drivers/net/ice/ice_fdir_filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 092c704503..5cba56918a 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -1780,6 +1780,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, * ethertype, if the spec is for all valid * packet id, set ethertype into input set. */ + flow_type = ICE_FLTR_PTYPE_FRAG_IPV4; *input_set |= ICE_INSET_ETHERTYPE; input_set_o |= ICE_INSET_ETHERTYPE; } else if (ipv4_mask->hdr.packet_id == UINT16_MAX) { -- 2.17.1