From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07835C4338F for ; Sat, 14 Aug 2021 17:01:03 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 82D7160E76 for ; Sat, 14 Aug 2021 17:01:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82D7160E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 634ED40696; Sat, 14 Aug 2021 19:01:01 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 0BFCB4068F for ; Sat, 14 Aug 2021 19:01:00 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id d4so25951819lfk.9 for ; Sat, 14 Aug 2021 10:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AyPTJOV+/Cw1/8i05symKM7dDBRVN+XTjVHuY8I2MM8=; b=g0iJuGpQ/EGoM0bcirYNBmsEeBa5QcP188rJfLpkpK7c0mIGbg7RxPBViGoopyC2y4 gP5zAdRNUGYDDcDQCtwsF6h3GlmiDKovroeLykI1+OZKpfdoCSy1jFOGzXfhBt+qJ5K3 MZ3eF//g2ZhjDpAKgfiHjBlL1aCKederYIUqX0lQ7CCby+/fZyunMVo1eQfF/SIAXs2D 6CSdCeeiclcLLBhc7lDEddCM8+j+xZtgi/vGQkO02jDtEa6cnphCJttrpYtOrfD7032n HffkQGMJ1gDh9gNaFBeudv/cVDZBRg6vQ6iOczJjGhGiz92KqEf/dQEOsp3rjEDrrIhK YB4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AyPTJOV+/Cw1/8i05symKM7dDBRVN+XTjVHuY8I2MM8=; b=YktK0hATkSySwxsAsONFnX/+eE8p3U7rMiFXWWfdyIpFrkZYbv8iasNQ9wxsr4wWCJ AomuNhGWankad+/b4K9xaTlt2GaceCPoFD+HWOzAvobb94l11MWYPRzZ1hwk3BxW43to ENHooFA42grZJeH9a+QHTmfVGiGbFPAyrEQQK9TBS03D7buePQbCLfkXgZzuK1nICJie mxPQA+ahfJpRHB8FaLa/Iw192gPYZSZIkonbTfyHWphpvX53LZ6PkWndbXdZWNL+Y5MQ RJXmOjk6v66FfZuK1uO8AUeDNRxeNjDbTNhOaC/aj+I0YHnd5mxFsBa44wx9n4V71QQd f1UQ== X-Gm-Message-State: AOAM530mpMSBXNz795XVnl13/DbDZhyWj2Q1TXGan16+zfym5Kv+MfLU CV7wJtpC46b8C4vfBglu5KY= X-Google-Smtp-Source: ABdhPJxh64qfxEnAdYseDdmPYZJ5FxmqK7qN5mP1cFd55DCssdherMvfEbXae1C9GQ/jO8vsHw/VYw== X-Received: by 2002:a19:c514:: with SMTP id w20mr5597942lfe.470.1628960459569; Sat, 14 Aug 2021 10:00:59 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id k17sm553254ljm.7.2021.08.14.10.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 10:00:58 -0700 (PDT) Date: Sat, 14 Aug 2021 20:00:57 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dpdk-dev Message-ID: <20210814200057.35207d86@sovereign> In-Reply-To: References: <20200227071126.75162e92@Sovereign> <20200228060727.192491-1-dmitry.kozliuk@gmail.com> <20200228060727.192491-6-dmitry.kozliuk@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-08-14 08:55 (UTC-0700), William Tu: > Hi Dmitry, > > I'm looking at this patch and have some questions. > > On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk > wrote: > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > drivers/net/virtio/virtio_ethdev.c | 4 + > > kernel/windows/netuio/netuio.inf | 6 + > > lib/librte_eal/windows/eal/eal.c | 4 + > > Why do we need these change below? 1. At the time of the patch there was no dpdk-kmods repo. 2. The patch is for dpdk-draft-windows repo, which was using Vistual Studio projects instead of meson. > I thought to add a new Windows driver support, we only need to > compile the drivers/net/xxx, and add the device ID to netuio.inf, > at the dpdk-kmod repo? Yes. Particularly for virtio it would also be required to support reading PCI config space in bus/pci/windows (netuio already provides the support). > > > mk/exec-env/windows/dpdk.sln | 754 +++++++++--------- > > mk/exec-env/windows/l2fwd/l2fwd.vcxproj | 242 +++--- > > mk/exec-env/windows/l3fwd/l3fwd.vcxproj | 292 +++---- > > .../librte_pmd_i40e.vcxproj.filters | 198 +++++ > > .../librte_pmd_net_virtio.vcxproj | 129 +++ > > 8 files changed, 989 insertions(+), 640 deletions(-) > > create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_i40e.vcxproj.filters > > create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_net_virtio.vcxproj > > Thanks > William